This repository has been archived by the owner on Jul 26, 2023. It is now read-only.
Add cabinet API #471
Merged
Add cabinet API #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
qmfrederik
commented
Jun 30, 2020
qmfrederik
commented
- FDICreate
- FDICopy
- FDIDestroy
- FDICreate - FDICopy - FDIDestroy
AArnott
reviewed
Jul 1, 2020
|
@AArnott Thanks for the review! I addressed your comments. I mainly marked the PR as draft because there are a bunch of other PRs open and I didn't want to flood you with PRs 😄 . |
AArnott
suggested changes
Jul 1, 2020
README.md
Outdated
| @@ -95,6 +95,7 @@ user32.dll |`PInvoke.User32` | [](https://www.nuget.org/packages/PInvoke.Userenv)|Windows User Environment | |||
| uxtheme.dll |`PInvoke.UxTheme` | [](https://www.nuget.org/packages/PInvoke.UxTheme)|[Windows Visual Styles][UxTheme] | |||
| WtsApi32.dll |`PInvoke.WtsApi32`| [](https://www.nuget.org/packages/PInvoke.WtsApi32)|[Windows Remote Desktop Services][WtsApi32] | |||
| cabinet.dll |`PInvoke.Cabinet` | [](https://www.nuget.org/packages/PInvoke.Cabinet)|[Cabinet API Functions][Cabinet] | |||
There was a problem hiding this comment.
Please keep the table sorted. (if there's a pre-existing sorting error, feel free to fix it)
src/Cabinet/Cabinet.cs
Outdated
| public delegate uint FNSEEK(int hf, int dist, SeekOrigin seektype); | ||
|
|
||
| [UnmanagedFunctionPointer(CallingConvention.Cdecl)] | ||
| public delegate int PFNNOTIFY(NOTIFICATIONTYPE fdint, NOTIFICATION fdin); |
There was a problem hiding this comment.
You've done a great job with docs everywhere else. Is this one missing docs because no docs exist, or was it an oversight? This wouldn't be a reason to deny merging a PR, but I wanted to give you a chance to fill it in.
src/Cabinet/Cabinet.cs
Outdated
Comment on lines
168
to
169
| [Friendly(FriendlyFlags.Out)] | ||
| ERF* perf); |
There was a problem hiding this comment.
One line per parameter, please.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.