Write file reference with correct capitalisation#8890
Merged
drewnoakes merged 1 commit intodotnet:mainfrom Mar 2, 2023
Merged
Conversation
When dragging a file from Solution Explorer into the Managed Resources editor, the file path is written to the `.resx` file in lower case. This is because the "drop data" provided by Solution Explorer contains a lower-case path (both for SDK-style and legacy projects). To fix this, we walk the path, using `Path.EnumerateFileSystemEntries` to produce a correctly cased path for the file being dragged. Unfortunately there's no better way I could find to achieve this. I tried quite a few different approaches and this seemed like the least rubbish. The approach used in `GetFileNameInActualCase` elsewhere in the resource editor only handles the file name, not any directories above it.
drewnoakes
added
the
Feature-Resource-Designer
MiYanni
approved these changes
Mar 2, 2023
Member
MiYanni
left a comment
MiYanni
left a comment
There was a problem hiding this comment.
I did some research after seeing this PR, and it does seem like an annoying situation to resolve. I believe this solution to be completely reasonable.
melytc
approved these changes
Mar 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes AB#1757141
When dragging a file from Solution Explorer into the Managed Resources editor, the file path is written to the
.resxfile in lower case.This is because the "drop data" provided by Solution Explorer contains a lower-case path (both for SDK-style and legacy projects).
To fix this, we walk the path, using
Path.EnumerateFileSystemEntriesto produce a correctly cased path for the file being dragged. Unfortunately there's no better way I could find to achieve this. I tried quite a few different approaches and this seemed like the least rubbish. The approach used inGetFileNameInActualCaseelsewhere in the resource editor only handles the file name, not any directories above it.This issue has been reported in various feedback tickets and has attracted a significant amount of attention/votes.
Microsoft Reviewers: Open in CodeFlow