Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't throw away C# diagnostics if Web Tools returns null #8205

Merged

Conversation

davidwengier
Copy link
Contributor

@davidwengier davidwengier requested a review from a team as a code owner February 2, 2023 00:08
return null;
// Important that we send back an empty list here, because null would result it the above method throwing away any other
// diagnostics it receives from the other delegated server
return Array.Empty<VSInternalDiagnosticReport>();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just change line 1171 to allow null for html diagnostics?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because @ryanbrandenburg added it as part of getting diagnostic integration tests to pass, so there must be scenarios where it sometimes happens. Basically I'm assuming that he and I are both right, and the current break is just the confluence of our two code changes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷

works for me. Test would be nice but I don't think should block this (and I also don't remember how easy it is to mock out the HTML server for testing)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are tests... integration tests... that are skipped right now

@davidwengier davidwengier merged commit 6c36b27 into dotnet:release/dev17.6 Feb 2, 2023
@davidwengier davidwengier deleted the FixDiagnostics176P1 branch February 2, 2023 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants