Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventLoopScheduler SemaphoreFullException #44

Closed
mattpodwysocki opened this issue Oct 13, 2014 · 4 comments
Closed

EventLoopScheduler SemaphoreFullException #44

mattpodwysocki opened this issue Oct 13, 2014 · 4 comments

Comments

@mattpodwysocki
Copy link
Contributor

Copied from https://rx.codeplex.com/workitem/37

EventLoopScheduler.Schedule may throw SemaphoreFullException. It appears that it may be due to a couple of race conditions in the Run method:

  1. Between the call to Wait and acquisition of the lock.
  2. Dequeueing expired items in a loop, without calling Wait for each item.

Related discussion:
http://social.msdn.microsoft.com/Forums/en-US/rx/thread/223f2447-4cb9-47ce-be21-6fd0e5b45e30/?prof=required

@mattpodwysocki
Copy link
Contributor Author

malayeri wrote Nov 5, 2013 at 5:00 PM

Dave, your proposed fix on the forum thread looks like it could work, but I'm a bit nervous about changing any kind of concurrency code. Would you be able to submit a pull request, or alternatively, review any code changes I make?

Thanks!

@mattpodwysocki
Copy link
Contributor Author

davedev wrote Nov 5, 2013 at 10:05 PM

Sure, I'll fix it and include a unit test. I'll make some time next weekend if that's alright.

@mattpodwysocki
Copy link
Contributor Author

malayeri wrote Nov 5, 2013 at 10:55 PM

That would be great! Thanks! We plan to do a release of Rx around early December, so this timing would be perfect.

@mattpodwysocki
Copy link
Contributor Author

davedev wrote Nov 10, 2013 at 5:40 PM

Submitted pull request:
https://rx.codeplex.com/SourceControl/network/forks/davedev/EventLoopSchedulerFix/contribution/5647

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant