Skip to content

4.x: SequenceEqual() initialization cleanup #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielcweber merged 1 commit into from
Jun 28, 2018
Merged

4.x: SequenceEqual() initialization cleanup #691

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions Rx.NET/Source/src/System.Reactive/Linq/Observable/SequenceEqual.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,29 +30,26 @@ public Observable(IObservable<TSource> first, IObservable<TSource> second, IEqua
internal sealed class _ : IdentitySink<bool>
{
private readonly IEqualityComparer<TSource> _comparer;
private readonly object _gate;
private readonly Queue<TSource> _ql;
private readonly Queue<TSource> _qr;

public _(IEqualityComparer<TSource> comparer, IObserver<bool> observer)
: base(observer)
{
_comparer = comparer;
_gate = new object();
_ql = new Queue<TSource>();
_qr = new Queue<TSource>();
}

private object _gate;
private bool _donel;
private bool _doner;
private Queue<TSource> _ql;
private Queue<TSource> _qr;

private IDisposable _second;

public void Run(Observable parent)
{
_gate = new object();
_donel = false;
_doner = false;
_ql = new Queue<TSource>();
_qr = new Queue<TSource>();

SetUpstream(parent._first.SubscribeSafe(new FirstObserver(this)));
Disposable.SetSingle(ref _second, parent._second.SubscribeSafe(new SecondObserver(this)));
}
Expand Down