From db4610336693197c188ec3a95e7cae59585d897c Mon Sep 17 00:00:00 2001 From: akarnokd Date: Thu, 28 Jun 2018 15:00:34 +0200 Subject: [PATCH] 4.x: Sum() don't init to default values --- .../src/System.Reactive/Linq/Observable/Sum.cs | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/Rx.NET/Source/src/System.Reactive/Linq/Observable/Sum.cs b/Rx.NET/Source/src/System.Reactive/Linq/Observable/Sum.cs index e5d87929b8..519ec3bed9 100644 --- a/Rx.NET/Source/src/System.Reactive/Linq/Observable/Sum.cs +++ b/Rx.NET/Source/src/System.Reactive/Linq/Observable/Sum.cs @@ -24,7 +24,6 @@ internal sealed class _ : IdentitySink public _(IObserver observer) : base(observer) { - _sum = 0.0; } public override void OnNext(double value) @@ -55,12 +54,11 @@ public SumSingle(IObservable source) internal sealed class _ : IdentitySink { - private double _sum; // This is what LINQ to Objects does! + private double _sum; // This is what LINQ to Objects does (accumulates into double that is)! public _(IObserver observer) : base(observer) { - _sum = 0.0; // This is what LINQ to Objects does! } public override void OnNext(float value) @@ -96,7 +94,6 @@ internal sealed class _ : IdentitySink public _(IObserver observer) : base(observer) { - _sum = 0M; } public override void OnNext(decimal value) @@ -132,7 +129,6 @@ internal sealed class _ : IdentitySink public _(IObserver observer) : base(observer) { - _sum = 0; } public override void OnNext(int value) @@ -178,7 +174,6 @@ internal sealed class _ : IdentitySink public _(IObserver observer) : base(observer) { - _sum = 0L; } public override void OnNext(long value) @@ -224,7 +219,6 @@ internal sealed class _ : IdentitySink public _(IObserver observer) : base(observer) { - _sum = 0.0; } public override void OnNext(double? value) @@ -256,12 +250,11 @@ public SumSingleNullable(IObservable source) internal sealed class _ : IdentitySink { - private double _sum; // This is what LINQ to Objects does! + private double _sum; // This is what LINQ to Objects does (accumulates into double that is)! public _(IObserver observer) : base(observer) { - _sum = 0.0; // This is what LINQ to Objects does! } public override void OnNext(float? value) @@ -298,7 +291,6 @@ internal sealed class _ : IdentitySink public _(IObserver observer) : base(observer) { - _sum = 0M; } public override void OnNext(decimal? value) @@ -335,7 +327,6 @@ internal sealed class _ : IdentitySink public _(IObserver observer) : base(observer) { - _sum = 0; } public override void OnNext(int? value) @@ -382,7 +373,6 @@ internal sealed class _ : IdentitySink public _(IObserver observer) : base(observer) { - _sum = 0L; } public override void OnNext(long? value)