From 56bec2df3e95e26bdb55465a0b3af090b6fe65c8 Mon Sep 17 00:00:00 2001 From: Oleksandr Didyk Date: Tue, 25 Apr 2023 16:02:16 +0000 Subject: [PATCH] Enable pre-built detection - Move various Microsoft.CodeAnalysis version numbers into Versions.props (some were already this way) - When in source-build mode, use the latest (testing) version across the board, which is closer to what will be used in full source build - When in normal repo build mode, use the individual versions. - Baseline a few dependencies that are executed or redistributed and cannot be satisfied by reference package. This should remove the need for the current RA source build patch --- Directory.Build.props | 7 +++ NuGet.config | 1 + eng/SourceBuildPrebuiltBaseline.xml | 17 +++++- eng/Version.Details.xml | 26 +++++--- eng/Versions.props | 59 ++++++++++++++----- src/Directory.Build.targets | 2 +- .../MetaAnalyzers/Fixers/PreferIsKindFix.cs | 2 +- ...ft.CodeAnalysis.Analyzers.UnitTests.csproj | 3 +- ...eAnalysis.CSharp.BannedApiAnalyzers.csproj | 2 +- ...oft.CodeAnalysis.BannedApiAnalyzers.csproj | 2 +- ...ysis.VisualBasic.BannedApiAnalyzers.vbproj | 2 +- ...Analysis.ResxSourceGenerator.CSharp.csproj | 2 +- ...lysis.ResxSourceGenerator.UnitTests.csproj | 2 +- ...sis.ResxSourceGenerator.VisualBasic.csproj | 2 +- ...ft.CodeAnalysis.ResxSourceGenerator.csproj | 2 +- ...isableRuntimeMarshalling.FixAllProvider.cs | 2 +- .../DoNotDirectlyAwaitATask.Fixer.cs | 2 +- .../Runtime/UseExceptionThrowHelpersFixer.cs | 2 +- ...CodeAnalysis.NetAnalyzers.UnitTests.csproj | 3 +- ...Sharp.PerformanceSensitiveAnalyzers.csproj | 2 +- ...ormanceSensitiveAnalyzers.CodeFixes.csproj | 2 +- ...lysis.PerformanceSensitiveAnalyzers.csproj | 2 +- ...oft.CodeAnalysis.PublicApiAnalyzers.csproj | 2 +- ...alysis.PublicApiAnalyzers.CodeFixes.csproj | 2 +- ...alysis.PublicApiAnalyzers.UnitTests.csproj | 3 +- ...Roslyn.Diagnostics.CSharp.Analyzers.csproj | 3 +- .../Core/Roslyn.Diagnostics.Analyzers.csproj | 2 +- ...lyn.Diagnostics.Analyzers.UnitTests.csproj | 3 +- ...n.Diagnostics.VisualBasic.Analyzers.vbproj | 3 +- ...GenerateDocumentationAndConfigFiles.csproj | 2 +- ...ationAndConfigFilesForBrokenRuntime.csproj | 6 +- .../ReleaseNotesUtil/ReleaseNotesUtil.csproj | 1 + 32 files changed, 120 insertions(+), 53 deletions(-) diff --git a/Directory.Build.props b/Directory.Build.props index 8fabbde4b2..f7efa2f840 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -45,6 +45,13 @@ $(NoWarn),1573,1591,1712 + + + $(NoWarn);CS8600;CS0618;CS8601;CS8602;CS8603;CS8604 + $(NoWarn);CS8605;CS8609;CS8618;CS8619;CS8620;CS8621;CS8625;CS8631;CS8714;CS8762;CS8765 + + true diff --git a/NuGet.config b/NuGet.config index 1fb0df5480..ea083a19de 100644 --- a/NuGet.config +++ b/NuGet.config @@ -6,6 +6,7 @@ + diff --git a/eng/SourceBuildPrebuiltBaseline.xml b/eng/SourceBuildPrebuiltBaseline.xml index c1b6dfbf05..dd107ed09d 100644 --- a/eng/SourceBuildPrebuiltBaseline.xml +++ b/eng/SourceBuildPrebuiltBaseline.xml @@ -1,5 +1,18 @@ + - + + + + + + + + + + + - + \ No newline at end of file diff --git a/eng/Version.Details.xml b/eng/Version.Details.xml index 1629ab8888..116136d9e0 100644 --- a/eng/Version.Details.xml +++ b/eng/Version.Details.xml @@ -5,6 +5,16 @@ https://github.com/dotnet/roslyn 66a912c9463eebe832cf742d2fe8bb2e1a4600ec + + https://github.com/dotnet/source-build-reference-packages + 05b4fdac346e01716abda4c92fcf0b7880e73792 + + + + https://github.com/dotnet/source-build-externals + de4dda48d0cf31e13182bc24107b2246c61ed483 + + @@ -12,15 +22,17 @@ fb6291b40fa4334dbd167e2071953e83cc8b9fdc - - https://github.com/dotnet/roslyn - 6a5a63bbc9f4449d9bd1e95a8f9624939c3ccdc3 + + https://github.com/dotnet/sourcelink + 47c52dd2ebf9edfd40abdcff999c13eb461f6ce2 + - - https://github.com/dotnet/roslyn - 6a5a63bbc9f4449d9bd1e95a8f9624939c3ccdc3 + + https://github.com/dotnet/xliff-tasks + 3f7d6c7e742012d9437fcb0d04cac63202d37621 + - + https://github.com/dotnet/roslyn 6a5a63bbc9f4449d9bd1e95a8f9624939c3ccdc3 diff --git a/eng/Versions.props b/eng/Versions.props index d770318df5..61d617338f 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -1,18 +1,5 @@ - - - $(SystemCollectionsImmutableVersion) - 5.0.0 - $(SystemReflectionMetadataVersion) - 5.0.0 - $(MicrosoftCodeAnalysisVersion) - 3.8.0 - 3.3.5 beta1 @@ -40,12 +27,52 @@ true 4.5.0 + 4.5.0 4.5.0 - - 3.3.1 - 3.7.0 + + + 4.6.0-1.final 4.6.0-1.final + 3.7.0 + 1.2.1 + 2.9.0 + 2.9.0 + 4.0.1 + + 3.3.1 + $(MicrosoftCodeAnalysisVersionForSourceBuild) 3.3.4 8.0.0-preview1.22621.6 $(DogfoodAnalyzersVersion) diff --git a/src/Directory.Build.targets b/src/Directory.Build.targets index 09112d02c2..fa5268fdf5 100644 --- a/src/Directory.Build.targets +++ b/src/Directory.Build.targets @@ -33,7 +33,7 @@ - + diff --git a/src/Microsoft.CodeAnalysis.Analyzers/Core/MetaAnalyzers/Fixers/PreferIsKindFix.cs b/src/Microsoft.CodeAnalysis.Analyzers/Core/MetaAnalyzers/Fixers/PreferIsKindFix.cs index 7a6877e0ea..a0cbd06e72 100644 --- a/src/Microsoft.CodeAnalysis.Analyzers/Core/MetaAnalyzers/Fixers/PreferIsKindFix.cs +++ b/src/Microsoft.CodeAnalysis.Analyzers/Core/MetaAnalyzers/Fixers/PreferIsKindFix.cs @@ -48,7 +48,7 @@ private async Task ConvertKindToIsKindAsync(Document document, TextSpa protected abstract void FixDiagnostic(DocumentEditor editor, SyntaxNode nodeToFix); - private sealed class CustomFixAllProvider : DocumentBasedFixAllProvider + private sealed class CustomFixAllProvider : Analyzer.Utilities.DocumentBasedFixAllProvider { private readonly PreferIsKindFix _fixer; diff --git a/src/Microsoft.CodeAnalysis.Analyzers/UnitTests/Microsoft.CodeAnalysis.Analyzers.UnitTests.csproj b/src/Microsoft.CodeAnalysis.Analyzers/UnitTests/Microsoft.CodeAnalysis.Analyzers.UnitTests.csproj index d55ed40d39..72426e4689 100644 --- a/src/Microsoft.CodeAnalysis.Analyzers/UnitTests/Microsoft.CodeAnalysis.Analyzers.UnitTests.csproj +++ b/src/Microsoft.CodeAnalysis.Analyzers/UnitTests/Microsoft.CodeAnalysis.Analyzers.UnitTests.csproj @@ -3,9 +3,10 @@ $(NetCurrent) true + $(MicrosoftCodeAnalysisVersionForTests) - + diff --git a/src/Microsoft.CodeAnalysis.BannedApiAnalyzers/CSharp/Microsoft.CodeAnalysis.CSharp.BannedApiAnalyzers.csproj b/src/Microsoft.CodeAnalysis.BannedApiAnalyzers/CSharp/Microsoft.CodeAnalysis.CSharp.BannedApiAnalyzers.csproj index 47c3703b5c..9ecb7dd7a9 100644 --- a/src/Microsoft.CodeAnalysis.BannedApiAnalyzers/CSharp/Microsoft.CodeAnalysis.CSharp.BannedApiAnalyzers.csproj +++ b/src/Microsoft.CodeAnalysis.BannedApiAnalyzers/CSharp/Microsoft.CodeAnalysis.CSharp.BannedApiAnalyzers.csproj @@ -2,7 +2,7 @@ netstandard2.0 - 2.9.0 + $(MicrosoftCodeAnalysisVersionForBannedApiAnalyzers) diff --git a/src/Microsoft.CodeAnalysis.BannedApiAnalyzers/Core/Microsoft.CodeAnalysis.BannedApiAnalyzers.csproj b/src/Microsoft.CodeAnalysis.BannedApiAnalyzers/Core/Microsoft.CodeAnalysis.BannedApiAnalyzers.csproj index 6ec9075648..750e007bf7 100644 --- a/src/Microsoft.CodeAnalysis.BannedApiAnalyzers/Core/Microsoft.CodeAnalysis.BannedApiAnalyzers.csproj +++ b/src/Microsoft.CodeAnalysis.BannedApiAnalyzers/Core/Microsoft.CodeAnalysis.BannedApiAnalyzers.csproj @@ -7,7 +7,7 @@ Restore would conclude that there is a cyclic dependency between us and the Microsoft.CodeAnalysis.BannedApiAnalyzer package. --> *$(MSBuildProjectFile)* - 2.9.0 + $(MicrosoftCodeAnalysisVersionForBannedApiAnalyzers) diff --git a/src/Microsoft.CodeAnalysis.BannedApiAnalyzers/VisualBasic/Microsoft.CodeAnalysis.VisualBasic.BannedApiAnalyzers.vbproj b/src/Microsoft.CodeAnalysis.BannedApiAnalyzers/VisualBasic/Microsoft.CodeAnalysis.VisualBasic.BannedApiAnalyzers.vbproj index f43d9bcece..8fa03af0ce 100644 --- a/src/Microsoft.CodeAnalysis.BannedApiAnalyzers/VisualBasic/Microsoft.CodeAnalysis.VisualBasic.BannedApiAnalyzers.vbproj +++ b/src/Microsoft.CodeAnalysis.BannedApiAnalyzers/VisualBasic/Microsoft.CodeAnalysis.VisualBasic.BannedApiAnalyzers.vbproj @@ -2,7 +2,7 @@ netstandard2.0 - 2.9.0 + $(MicrosoftCodeAnalysisVersionForBannedApiAnalyzers) diff --git a/src/Microsoft.CodeAnalysis.ResxSourceGenerator/Microsoft.CodeAnalysis.ResxSourceGenerator.CSharp/Microsoft.CodeAnalysis.ResxSourceGenerator.CSharp.csproj b/src/Microsoft.CodeAnalysis.ResxSourceGenerator/Microsoft.CodeAnalysis.ResxSourceGenerator.CSharp/Microsoft.CodeAnalysis.ResxSourceGenerator.CSharp.csproj index 201584f8d2..bd14e9dc2a 100644 --- a/src/Microsoft.CodeAnalysis.ResxSourceGenerator/Microsoft.CodeAnalysis.ResxSourceGenerator.CSharp/Microsoft.CodeAnalysis.ResxSourceGenerator.CSharp.csproj +++ b/src/Microsoft.CodeAnalysis.ResxSourceGenerator/Microsoft.CodeAnalysis.ResxSourceGenerator.CSharp/Microsoft.CodeAnalysis.ResxSourceGenerator.CSharp.csproj @@ -7,7 +7,7 @@ *$(MSBuildProjectFile)* - 4.0.1 + $(MicrosoftCodeAnalysisVersionForResxSourceGenerators) diff --git a/src/Microsoft.CodeAnalysis.ResxSourceGenerator/Microsoft.CodeAnalysis.ResxSourceGenerator.UnitTests/Microsoft.CodeAnalysis.ResxSourceGenerator.UnitTests.csproj b/src/Microsoft.CodeAnalysis.ResxSourceGenerator/Microsoft.CodeAnalysis.ResxSourceGenerator.UnitTests/Microsoft.CodeAnalysis.ResxSourceGenerator.UnitTests.csproj index 92baad4a68..ef97030435 100644 --- a/src/Microsoft.CodeAnalysis.ResxSourceGenerator/Microsoft.CodeAnalysis.ResxSourceGenerator.UnitTests/Microsoft.CodeAnalysis.ResxSourceGenerator.UnitTests.csproj +++ b/src/Microsoft.CodeAnalysis.ResxSourceGenerator/Microsoft.CodeAnalysis.ResxSourceGenerator.UnitTests/Microsoft.CodeAnalysis.ResxSourceGenerator.UnitTests.csproj @@ -5,7 +5,7 @@ true true - 4.0.1 + $(MicrosoftCodeAnalysisVersionForResxSourceGenerators) diff --git a/src/Microsoft.CodeAnalysis.ResxSourceGenerator/Microsoft.CodeAnalysis.ResxSourceGenerator.VisualBasic/Microsoft.CodeAnalysis.ResxSourceGenerator.VisualBasic.csproj b/src/Microsoft.CodeAnalysis.ResxSourceGenerator/Microsoft.CodeAnalysis.ResxSourceGenerator.VisualBasic/Microsoft.CodeAnalysis.ResxSourceGenerator.VisualBasic.csproj index db8abd352a..be8f9e03ea 100644 --- a/src/Microsoft.CodeAnalysis.ResxSourceGenerator/Microsoft.CodeAnalysis.ResxSourceGenerator.VisualBasic/Microsoft.CodeAnalysis.ResxSourceGenerator.VisualBasic.csproj +++ b/src/Microsoft.CodeAnalysis.ResxSourceGenerator/Microsoft.CodeAnalysis.ResxSourceGenerator.VisualBasic/Microsoft.CodeAnalysis.ResxSourceGenerator.VisualBasic.csproj @@ -7,7 +7,7 @@ *$(MSBuildProjectFile)* - 4.0.1 + $(MicrosoftCodeAnalysisVersionForResxSourceGenerators) diff --git a/src/Microsoft.CodeAnalysis.ResxSourceGenerator/Microsoft.CodeAnalysis.ResxSourceGenerator/Microsoft.CodeAnalysis.ResxSourceGenerator.csproj b/src/Microsoft.CodeAnalysis.ResxSourceGenerator/Microsoft.CodeAnalysis.ResxSourceGenerator/Microsoft.CodeAnalysis.ResxSourceGenerator.csproj index 17b5607828..5fb1a057a6 100644 --- a/src/Microsoft.CodeAnalysis.ResxSourceGenerator/Microsoft.CodeAnalysis.ResxSourceGenerator/Microsoft.CodeAnalysis.ResxSourceGenerator.csproj +++ b/src/Microsoft.CodeAnalysis.ResxSourceGenerator/Microsoft.CodeAnalysis.ResxSourceGenerator/Microsoft.CodeAnalysis.ResxSourceGenerator.csproj @@ -7,7 +7,7 @@ *$(MSBuildProjectFile)* - 4.0.1 + $(MicrosoftCodeAnalysisVersionForResxSourceGenerators) diff --git a/src/NetAnalyzers/CSharp/Microsoft.NetCore.Analyzers/InteropServices/CSharpDisableRuntimeMarshalling.FixAllProvider.cs b/src/NetAnalyzers/CSharp/Microsoft.NetCore.Analyzers/InteropServices/CSharpDisableRuntimeMarshalling.FixAllProvider.cs index 9bdd8f1def..04c1ab1c5c 100644 --- a/src/NetAnalyzers/CSharp/Microsoft.NetCore.Analyzers/InteropServices/CSharpDisableRuntimeMarshalling.FixAllProvider.cs +++ b/src/NetAnalyzers/CSharp/Microsoft.NetCore.Analyzers/InteropServices/CSharpDisableRuntimeMarshalling.FixAllProvider.cs @@ -15,7 +15,7 @@ namespace Microsoft.NetCore.Analyzers.InteropServices { public sealed partial class CSharpDisableRuntimeMarshallingFixer { - private class CustomFixAllProvider : DocumentBasedFixAllProvider + private class CustomFixAllProvider : Analyzer.Utilities.DocumentBasedFixAllProvider { public static readonly CustomFixAllProvider Instance = new(); diff --git a/src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/ApiDesignGuidelines/DoNotDirectlyAwaitATask.Fixer.cs b/src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/ApiDesignGuidelines/DoNotDirectlyAwaitATask.Fixer.cs index 331c0a4fec..492d0d4c1b 100644 --- a/src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/ApiDesignGuidelines/DoNotDirectlyAwaitATask.Fixer.cs +++ b/src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/ApiDesignGuidelines/DoNotDirectlyAwaitATask.Fixer.cs @@ -74,7 +74,7 @@ public sealed override FixAllProvider GetFixAllProvider() return CustomFixAllProvider.Instance; } - private sealed class CustomFixAllProvider : DocumentBasedFixAllProvider + private sealed class CustomFixAllProvider : Analyzer.Utilities.DocumentBasedFixAllProvider { public static readonly CustomFixAllProvider Instance = new(); diff --git a/src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/UseExceptionThrowHelpersFixer.cs b/src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/UseExceptionThrowHelpersFixer.cs index 82a3e986c0..336bd2a52d 100644 --- a/src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/UseExceptionThrowHelpersFixer.cs +++ b/src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/UseExceptionThrowHelpersFixer.cs @@ -121,7 +121,7 @@ public sealed override async Task RegisterCodeFixesAsync(CodeFixContext context) other is not null ? new SyntaxNode[] { arg, other } : new SyntaxNode[] { arg })).WithTriviaFrom(node)); } - private sealed class CustomFixAllProvider : DocumentBasedFixAllProvider + private sealed class CustomFixAllProvider : Analyzer.Utilities.DocumentBasedFixAllProvider { public static readonly CustomFixAllProvider Instance = new(); diff --git a/src/NetAnalyzers/UnitTests/Microsoft.CodeAnalysis.NetAnalyzers.UnitTests.csproj b/src/NetAnalyzers/UnitTests/Microsoft.CodeAnalysis.NetAnalyzers.UnitTests.csproj index f74eea729d..833ea83d24 100644 --- a/src/NetAnalyzers/UnitTests/Microsoft.CodeAnalysis.NetAnalyzers.UnitTests.csproj +++ b/src/NetAnalyzers/UnitTests/Microsoft.CodeAnalysis.NetAnalyzers.UnitTests.csproj @@ -4,9 +4,10 @@ $(NetCurrent) $(DefineConstants),NET_ANALYZERS_TEST true + $(MicrosoftCodeAnalysisVersionForTests) - + diff --git a/src/PerformanceSensitiveAnalyzers/CSharp/Analyzers/Microsoft.CodeAnalysis.CSharp.PerformanceSensitiveAnalyzers.csproj b/src/PerformanceSensitiveAnalyzers/CSharp/Analyzers/Microsoft.CodeAnalysis.CSharp.PerformanceSensitiveAnalyzers.csproj index 1f4ea3876a..2b18eb53cc 100644 --- a/src/PerformanceSensitiveAnalyzers/CSharp/Analyzers/Microsoft.CodeAnalysis.CSharp.PerformanceSensitiveAnalyzers.csproj +++ b/src/PerformanceSensitiveAnalyzers/CSharp/Analyzers/Microsoft.CodeAnalysis.CSharp.PerformanceSensitiveAnalyzers.csproj @@ -2,7 +2,7 @@ netstandard2.0 - 2.9.0 + $(MicrosoftCodeAnalysisVersionForPerfSensitiveAnalyzers) diff --git a/src/PerformanceSensitiveAnalyzers/CSharp/CodeFixes/Microsoft.CodeAnalysis.CSharp.PerformanceSensitiveAnalyzers.CodeFixes.csproj b/src/PerformanceSensitiveAnalyzers/CSharp/CodeFixes/Microsoft.CodeAnalysis.CSharp.PerformanceSensitiveAnalyzers.CodeFixes.csproj index d45eee74b4..3904c9ebd2 100644 --- a/src/PerformanceSensitiveAnalyzers/CSharp/CodeFixes/Microsoft.CodeAnalysis.CSharp.PerformanceSensitiveAnalyzers.CodeFixes.csproj +++ b/src/PerformanceSensitiveAnalyzers/CSharp/CodeFixes/Microsoft.CodeAnalysis.CSharp.PerformanceSensitiveAnalyzers.CodeFixes.csproj @@ -2,8 +2,8 @@ netstandard2.0 - 2.9.0 true + $(MicrosoftCodeAnalysisVersionForBannedApiAnalyzers) diff --git a/src/PerformanceSensitiveAnalyzers/Core/Microsoft.CodeAnalysis.PerformanceSensitiveAnalyzers.csproj b/src/PerformanceSensitiveAnalyzers/Core/Microsoft.CodeAnalysis.PerformanceSensitiveAnalyzers.csproj index 210efb52aa..22c592c5e9 100644 --- a/src/PerformanceSensitiveAnalyzers/Core/Microsoft.CodeAnalysis.PerformanceSensitiveAnalyzers.csproj +++ b/src/PerformanceSensitiveAnalyzers/Core/Microsoft.CodeAnalysis.PerformanceSensitiveAnalyzers.csproj @@ -7,7 +7,7 @@ Restore would conclude that there is a cyclic dependency between us and the Microsoft.CodeAnalysis.PerformanceSensitive.Analyzers nuget package. --> *$(MSBuildProjectFile)* - 2.9.0 + $(MicrosoftCodeAnalysisVersionForPerfSensitiveAnalyzers) diff --git a/src/PublicApiAnalyzers/Core/Analyzers/Microsoft.CodeAnalysis.PublicApiAnalyzers.csproj b/src/PublicApiAnalyzers/Core/Analyzers/Microsoft.CodeAnalysis.PublicApiAnalyzers.csproj index a569fafe9a..ba8c676459 100644 --- a/src/PublicApiAnalyzers/Core/Analyzers/Microsoft.CodeAnalysis.PublicApiAnalyzers.csproj +++ b/src/PublicApiAnalyzers/Core/Analyzers/Microsoft.CodeAnalysis.PublicApiAnalyzers.csproj @@ -7,7 +7,7 @@ Restore would conclude that there is a cyclic dependency between us and the Microsoft.CodeAnalysis.PublicApiAnalyzer package. --> *$(MSBuildProjectFile)* - 1.2.1 + $(MicrosoftCodeAnalysisVersionForPublicApiAnalyzers) diff --git a/src/PublicApiAnalyzers/Core/CodeFixes/Microsoft.CodeAnalysis.PublicApiAnalyzers.CodeFixes.csproj b/src/PublicApiAnalyzers/Core/CodeFixes/Microsoft.CodeAnalysis.PublicApiAnalyzers.CodeFixes.csproj index 41430c630f..c65e01cc8c 100644 --- a/src/PublicApiAnalyzers/Core/CodeFixes/Microsoft.CodeAnalysis.PublicApiAnalyzers.CodeFixes.csproj +++ b/src/PublicApiAnalyzers/Core/CodeFixes/Microsoft.CodeAnalysis.PublicApiAnalyzers.CodeFixes.csproj @@ -7,7 +7,7 @@ Restore would conclude that there is a cyclic dependency between us and the DotNetAnalyzers.PublicApiAnalyzer.CodeFixes package. --> *$(MSBuildProjectFile)* - 1.2.1 + $(MicrosoftCodeAnalysisVersionForPublicApiAnalyzers) true diff --git a/src/PublicApiAnalyzers/UnitTests/Microsoft.CodeAnalysis.PublicApiAnalyzers.UnitTests.csproj b/src/PublicApiAnalyzers/UnitTests/Microsoft.CodeAnalysis.PublicApiAnalyzers.UnitTests.csproj index bf5e3dc40e..4b33fc624c 100644 --- a/src/PublicApiAnalyzers/UnitTests/Microsoft.CodeAnalysis.PublicApiAnalyzers.UnitTests.csproj +++ b/src/PublicApiAnalyzers/UnitTests/Microsoft.CodeAnalysis.PublicApiAnalyzers.UnitTests.csproj @@ -3,9 +3,10 @@ $(NetCurrent) true + $(MicrosoftCodeAnalysisVersionForTests) - + diff --git a/src/Roslyn.Diagnostics.Analyzers/CSharp/Roslyn.Diagnostics.CSharp.Analyzers.csproj b/src/Roslyn.Diagnostics.Analyzers/CSharp/Roslyn.Diagnostics.CSharp.Analyzers.csproj index e62266894f..316c23359d 100644 --- a/src/Roslyn.Diagnostics.Analyzers/CSharp/Roslyn.Diagnostics.CSharp.Analyzers.csproj +++ b/src/Roslyn.Diagnostics.Analyzers/CSharp/Roslyn.Diagnostics.CSharp.Analyzers.csproj @@ -2,6 +2,7 @@ netstandard2.0 + $(MicrosoftCodeAnalysisForRoslynDiagnosticsAnalyzersVersion) @@ -10,7 +11,7 @@ - + \ No newline at end of file diff --git a/src/Roslyn.Diagnostics.Analyzers/Core/Roslyn.Diagnostics.Analyzers.csproj b/src/Roslyn.Diagnostics.Analyzers/Core/Roslyn.Diagnostics.Analyzers.csproj index 60450aee0e..0acfeca021 100644 --- a/src/Roslyn.Diagnostics.Analyzers/Core/Roslyn.Diagnostics.Analyzers.csproj +++ b/src/Roslyn.Diagnostics.Analyzers/Core/Roslyn.Diagnostics.Analyzers.csproj @@ -7,7 +7,7 @@ Restore would conclude that there is a cyclic dependency between us and the Roslyn.Diagnostics.Analyzers package. --> *$(MSBuildProjectFile)* - $(MicrosoftCodeAnalysisForRoslynDiagnosticsAnalyzersVersion) + $(MicrosoftCodeAnalysisForRoslynDiagnosticsAnalyzersVersion) diff --git a/src/Roslyn.Diagnostics.Analyzers/UnitTests/Roslyn.Diagnostics.Analyzers.UnitTests.csproj b/src/Roslyn.Diagnostics.Analyzers/UnitTests/Roslyn.Diagnostics.Analyzers.UnitTests.csproj index 884a46588e..e6c97a4d29 100644 --- a/src/Roslyn.Diagnostics.Analyzers/UnitTests/Roslyn.Diagnostics.Analyzers.UnitTests.csproj +++ b/src/Roslyn.Diagnostics.Analyzers/UnitTests/Roslyn.Diagnostics.Analyzers.UnitTests.csproj @@ -3,9 +3,10 @@ $(NetCurrent) true + $(MicrosoftCodeAnalysisVersionForTests) - + diff --git a/src/Roslyn.Diagnostics.Analyzers/VisualBasic/Roslyn.Diagnostics.VisualBasic.Analyzers.vbproj b/src/Roslyn.Diagnostics.Analyzers/VisualBasic/Roslyn.Diagnostics.VisualBasic.Analyzers.vbproj index 509a3c0698..91c347b805 100644 --- a/src/Roslyn.Diagnostics.Analyzers/VisualBasic/Roslyn.Diagnostics.VisualBasic.Analyzers.vbproj +++ b/src/Roslyn.Diagnostics.Analyzers/VisualBasic/Roslyn.Diagnostics.VisualBasic.Analyzers.vbproj @@ -2,12 +2,13 @@ netstandard2.0 + $(MicrosoftCodeAnalysisForRoslynDiagnosticsAnalyzersVersion) - + \ No newline at end of file diff --git a/src/Tools/GenerateDocumentationAndConfigFiles/GenerateDocumentationAndConfigFiles.csproj b/src/Tools/GenerateDocumentationAndConfigFiles/GenerateDocumentationAndConfigFiles.csproj index d2ea921afd..1712a12cc4 100644 --- a/src/Tools/GenerateDocumentationAndConfigFiles/GenerateDocumentationAndConfigFiles.csproj +++ b/src/Tools/GenerateDocumentationAndConfigFiles/GenerateDocumentationAndConfigFiles.csproj @@ -5,7 +5,7 @@ true false true - $(MicrosoftCodeAnalysisForRoslynDiagnosticsAnalyzersVersion) + $(MicrosoftCodeAnalysisForRoslynDiagnosticsAnalyzersVersion) diff --git a/src/Tools/GenerateDocumentationAndConfigFilesForBrokenRuntime/GenerateDocumentationAndConfigFilesForBrokenRuntime.csproj b/src/Tools/GenerateDocumentationAndConfigFilesForBrokenRuntime/GenerateDocumentationAndConfigFilesForBrokenRuntime.csproj index 8712631690..21e0eca4ab 100644 --- a/src/Tools/GenerateDocumentationAndConfigFilesForBrokenRuntime/GenerateDocumentationAndConfigFilesForBrokenRuntime.csproj +++ b/src/Tools/GenerateDocumentationAndConfigFilesForBrokenRuntime/GenerateDocumentationAndConfigFilesForBrokenRuntime.csproj @@ -5,6 +5,7 @@ true false true + $(MicrosoftCodeAnalysisForRoslynDiagnosticsAnalyzersVersion) @@ -12,8 +13,7 @@ - - - + + diff --git a/src/Tools/ReleaseNotesUtil/ReleaseNotesUtil.csproj b/src/Tools/ReleaseNotesUtil/ReleaseNotesUtil.csproj index 8652932055..28920a5a46 100644 --- a/src/Tools/ReleaseNotesUtil/ReleaseNotesUtil.csproj +++ b/src/Tools/ReleaseNotesUtil/ReleaseNotesUtil.csproj @@ -3,6 +3,7 @@ Exe $(NetCurrent) true + true