Emit CA1822 for recursive method. #6641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6641 +/- ##
========================================
Coverage 96.40% 96.40%
========================================
Files 1379 1377 -2
Lines 322186 322045 -141
Branches 10459 10434 -25
========================================
- Hits 310592 310472 -120
+ Misses 9102 9083 -19
+ Partials 2492 2490 -2 |
buyaa-n
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
MarkMembersAsStaticAnalyzercurrently checks if a method contains any instance reference operations. This PR adds an exclusion of the method itself, i.e. a recursive method, to that check.Fixes #6540