Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add long paths prerequisite to NetCore_GettingStarted.md #6653

Closed
wants to merge 2 commits into from

Conversation

carlossanlop
Copy link
Member

Improve documentation to prevent contributors from falling into this issue: #6632 (comment)

@buyaa-n
Copy link
Member

buyaa-n commented May 26, 2023

This is related to any build right? Maybe add into https://github.com/dotnet/roslyn-analyzers#getting-started?

@carlossanlop
Copy link
Member Author

This is related to any build right? Maybe add into https://github.com/dotnet/roslyn-analyzers#getting-started?

Ah, good point. I missed those instructions.

I think it's worth having this info in both places, if that's alright with you.

Copy link
Member

@sharwell sharwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should wait for dotnet/roslyn#68217 to merge and adopt the same strategy here.

@carlossanlop
Copy link
Member Author

@sharwell should that roslyn PR block this docs PR though? Can you please explain?

@sharwell
Copy link
Member

@carlossanlop I believe yes. Once the strategy from dotnet/roslyn is finalized, the documentation will be redundant because the build will perform the necessary change so the user doesn't need to. Also, the steps to enable the feature will be simplified to running a script which the error output points to.

@carlossanlop
Copy link
Member Author

The roslyn PR has been merged. @sharwell should I close this?

@carlossanlop carlossanlop deleted the carlossanlop-patch-1 branch June 14, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants