Skip to content
Permalink
Branch: master
Commits on Oct 16, 2019
  1. Using declaration ioperation (#39125)

    chsienki committed Oct 16, 2019
    * Update sln/csproj for generated ioperations
    * Extract BoundMultiple[Using/Local]Declaration into an abstract base node
    * Update VariableDeclarationGroupOperation for UsingDeclarations
    * Implement CFG for using declarations
    * Update and add tests
Commits on Oct 2, 2019
Commits on Aug 22, 2019
  1. Fix Build badges: (#37412)

    chsienki and sharwell committed Aug 22, 2019
    * Fix Build badges:
     - Update generate script
     - Update readme.me with latest run of script
    
    Co-Authored-By: Sam Harwell <sam@tunnelvisionlabs.com>
Commits on Jul 24, 2019
  1. Symbol equality comparer (#37247)

    chsienki authored and agocke committed Jul 24, 2019
    Fixes #35933
Commits on Jul 1, 2019
  1. Don't update analyzed nullability for parameter conversions (#36881)

    chsienki committed Jul 1, 2019
    * Don't update analyzed nullability for param conversions
    * Fix test types
Commits on Jun 26, 2019
  1. Use TestRuntimeAdditionalArguments from Arcade: (#34296)

    chsienki committed Jun 26, 2019
    - Remove invoke mono script
     - Pass through debug flag via supported arcade mechanism instead
Commits on Jun 25, 2019
  1. Semantic model tuple types (#36628)

    chsienki committed Jun 25, 2019
    * Correctly report nullability of tuples in the semantic model:
    - Store the original tuple literal rather than just its type
    - Visit the original literal without diagnostics only in the nullability walker to understand its type
    - Update the generator to allow force visiting fields in the nullable re-writer
    - Update type checker to allow checking of converted types too
    - Update various tuple tests to be correct
    - Add extra tests
Commits on Jun 17, 2019
  1. Fix parsing bug in invalid using statements (#36428)

    chsienki committed Jun 17, 2019
Commits on Jun 12, 2019
  1. Dont try and check tuple conversions in error cases: (#36188)

    chsienki committed Jun 12, 2019
    * Dont try and check tuple conversions in error cases:
    - When checking an identity converison, also check for a bound tuple if the type isn't a tuple as we might have a bound tuple with an error type
    - When checking a tuple conversion, don't GenerateConversion in the error case as we don't have a target type to generate against
    - Update tests
Commits on Jun 5, 2019
  1. Update implicity declared type expression nullability: (#36078)

    chsienki committed Jun 5, 2019
    * Update implicity declared type expression nullability:
    - When updating the implicit type in a declaration also update the bound type declaration nullability
    - Record nullability for inferred foreach variable
    - Add nullable public api tests
    - Add nullable tests
Commits on May 24, 2019
  1. Infer nested nullability for implicitly typed deconstruction variable: (

    chsienki committed May 24, 2019
    #35576)
    
    * Infer nested nullability for implicitly typed deconstruction variable:
    - When the left hand side is 'var', re-infer the type from the visited right hand side
    - Update and add tests
Commits on May 6, 2019
  1. Nullable Deconstruction in foreach loops: (#35445)

    chsienki committed May 6, 2019
    * Nullable Deconstruction in foreach loops:
    - Visit deconstruction in foreach loops, rather than handling it directly
    - Add tests
Commits on Apr 30, 2019
  1. Additional Nullability checks for deconstruction: (#35016)

    chsienki committed Apr 30, 2019
    * Additional Nullability checks for deconstruction:
    - Check 'this' param for extension deconstruct
    - Re-infer the argument types for generic extension deconstruct
    - Update the deconstruction method in instance cases
    - Update return type with visited arguments
    - Update tests
Commits on Apr 26, 2019
  1. Make Generated syntax trees restore to project-level nullability (#35018

    chsienki committed Apr 26, 2019
    )
    
    * Make Generated syntax trees restore to project nullability
Commits on Apr 25, 2019
  1. Re-enable symbol tests on mono (#35265)

    chsienki committed Apr 25, 2019
Commits on Apr 24, 2019
  1. Add spec for enhanced using (#34697)

    chsienki committed Apr 24, 2019
    * Add spec for enhanced using
Commits on Apr 18, 2019
  1. Update nullable attribute in docs (#34763)

    chsienki authored and jcouv committed Apr 18, 2019
    * Update nullable attribute in docs
    
    Update nullable attribute in docs to show NullableFlags
    
    * Update nullable-reference-types.md
Commits on Apr 8, 2019
  1. Handle nullability in recursive deconstruction: (#34768)

    chsienki committed Apr 8, 2019
    * Handle nullability in recursive deconstruction:
    - Recurse into nested deconstructions
    - Override visit VisitDeconstructValuePlaceholder to set the result as non null
    - Update tests
Commits on Mar 25, 2019
  1. Update Linux LLDB/SOS instructions (#34340)

    chsienki committed Mar 25, 2019
Commits on Mar 21, 2019
  1. Don't warn about #nullable in disabled code: (#34319)

    chsienki committed Mar 21, 2019
    * Don't warn about #nullable in disabled code:
     - Check if in an active code region before warning about #nullable  or #pragma directives in lower lang versions
     - Add tests
Commits on Mar 20, 2019
  1. Add extra nullable test for params: (#34293)

    chsienki committed Mar 20, 2019
    * Add extra nullable test for params:
     - Call out the difference in behavior between normal / expanded form invocation for nullable params parameters
  2. Only skip test on mono (#34262)

    chsienki committed Mar 20, 2019
    Update comment to to track status
Commits on Mar 15, 2019
  1. Warn on __refvalue null dereference: (#34135)

    chsienki committed Mar 15, 2019
    * Warn on __refvalue null dereference:
    - Store the nullable annotation of the type passed to __refvalue
    - Use that information in nullable walker to report nullability warnings
    - Add test
  2. Fix struct layout error when nullable enabled: (#34128)

    chsienki committed Mar 15, 2019
    * Fix struct layout error when nullable enabled:
    - Change type comparison to ignore nullable
    - Add a test
    - Fix an existing test
Commits on Mar 14, 2019
  1. Add the correct nullable annotations to generated iterator code (#33986)

    chsienki committed Mar 14, 2019
    This is mainly about plumbing through TypeWithAnnotations to the correct point so we can generate the attribute based on it's value.
    
    - Expose the IteratorElementType as a TypeWithAnnotations and rename to IteratorElementTypeWithAnnotations
    - Return the annotated type, or a default as needed from the required locations
    - Allow state machine field to take a TWA and pass it in via the iterator rewriter
    - Fix test
  2. Report nullability for attribute arguments: (#33816)

    chsienki committed Mar 14, 2019
    * Report nullability for attribute arguments:
    - Add an entry point to nullable walker for attribute analysis
    - Implement analyze attribute in the walker
    - Update MethodThisParameter to not throw
    - Add extra fields to BoundAttribute that are needed for nullable analysis
    - Add tests
    
    
    
    * PR Feedback:
    - Analyse attributes even when we don't bind a constructor
    
    - Add tests for when we don't bind constructor but still want to analyze what we have
    
    * PR Feedback:
    - fix typos
    - make no matching constructors use implicit constructors
    
    * Replace tabs with spaces
    
    * Fix failing test
Commits on Mar 13, 2019
  1. Fix failing test

    chsienki committed Mar 13, 2019
  2. Replace tabs with spaces

    chsienki committed Mar 12, 2019
  3. PR Feedback:

    chsienki committed Mar 12, 2019
    - fix typos
    - make no matching constructors use implicit constructors
  4. PR Feedback:

    chsienki committed Mar 12, 2019
    - Analyse attributes even when we don't bind a constructor
    - Don't assume we have a method symbol in enter parameters
    - Add tests for when we don't bind constructor but still want to analyze what we have
  5. PR Feedback:

    chsienki committed Mar 12, 2019
    - Move attribute nullable check to GetAttribute rather than bind attribute
  6. PR Feedback

    chsienki committed Mar 11, 2019
  7. PR Feedback:

    chsienki committed Mar 11, 2019
    - Change MethodThisParameter
    - Clean up nullable checks
    - Extra tests
  8. Fix failing tests:

    chsienki committed Mar 8, 2019
    - Don't do analysis for speculative attributes
    - Manually call TryGetThisParameter, rather than MethodThisParameter which can throw
Older
You can’t perform that action at this time.