Switch branches/tags
AddLangServiceSatelliteAssemblies-180725 AddSatelliteAssembliesToSetup-180719 ArcadeTargets ArcadeTest DemoBranch DsrDependency Fix432432 FixRunSettings Layout MattGal-patch-1 PublishJson158159 RefactorToolsOptions VSSetupDrop bugfix/update-composition-package consolidateGoToDef dev/JieCarolHu/kaseyDemo531_bugFixed dev/JieCarolHu/kaseyDemo531 dev/brettfo/async-package dev/brettfo/sign-files dev/brettfo/snippet-syntax-facts dev/brettfo/version-packages dev/chborl/completestatement dev/chborley/completestatement dev/chborley/completestatement2 dev/chsienki/dipose_pattern_ext_method dev/cston/refs-only dev/features/sharwell-async-package dev/frsilb/disable-incremental-binding dev/hechang/FarRazor3 dev/hechang/OOPCompletion dev/hechang/RazorFar5 dev/hechang/mockup dev/hechang/newOptProf2 dev/hechang/optimization dev/hechang/projectapi dev/hechang/razorCleanup dev/hechang/removeOptimization dev/hechang/serialization2 dev/hechang/serialization4 dev/jaredpar/fix-del dev/jaredpar/fix-nuget dev/jaredpar/fix-official dev/jaredpar/fix-pack dev/jaredpar/fix-process dev/jaredpar/fix-publish dev/jaredpar/fix-queue dev/jaredpar/fix-sign dev/jaredpar/sdk dev/jaredpar/staging-queue dev/jaredpar/swix dev/jasonmal/delete-immutablehashmap dev/jcouv/update-docs dev/jinuj/PR-23448 dev/jorobich/new-classifications dev/olegtk/ExportFixes dev/olegtk/testNavBarIcons2 dev/sharwell/async-package dev/sharwell/vs-threading-analyzers dev/shgu/15.9p2version dev/shgu/15.9p2 dev/tmat/PublishData15.9 dev/tmat/ibcversionfix dev/tmat/3.0.0 dev15-rc-ri dev15-rc2 dev15-rc3 dev15.0.x dev15.1.x dev15.2.x dev15.3-preview1 dev15.3-preview2 dev15.3.x dev15.4.x dev15.5-preview1-staging dev15.5-preview1 dev15.5.x dev15.6-preview1-vs-deps dev15.6-preview2-vs-deps dev15.6-preview2 dev15.6-preview3-vs-deps dev15.6-preview3 dev15.6.x-vs-deps dev15.6.x dev15.7-preview1-vs-deps dev15.7-preview1-with-hotfixes-vs-deps dev15.7-preview1 dev15.7-preview3-vs-deps dev15.7-preview3 dev15.7.x-vs-deps dev15.7.x dev15.8-preview2-vs-deps dev15.8-preview2 dev15.8-preview3-vs-deps dev15.8-preview3 dev15.8-preview4-vs-deps dev15.8-preview4 dev15.8.x-vs-deps dev15.8.x dev15.9-preview1-vs-deps dev15.9-preview1 dev15.9-preview2-vs-deps dev15.9-preview2 dev15.9-preview3-vs-deps dev15.9-preview3 dev15.9.x-vs-deps dev15.9.x dev16.0.x-vs-deps dev16.0.x dpoeschl-patch-1 editorconfig-ide enableOOPByDefault fastInitialTaggingMaster feature/move-integration-tests-to-APEX features/AnnotatedTypes features/AsyncCompletion features/DefaultInterfaceImplementation features/EditorCompletion158_2 features/ExpressionVariables features/IVTCompletionTests features/NegatedConditionStatements features/NullableDogfood features/NullableReferenceTypes features/async-streams features/build-demo features/caller-expression features/ci features/codecov features/compiler features/continuation-comments features/custom-fixed features/dataflow features/decon-default features/editorconfig-in-compiler features/embeddedJson features/embeddedRegex features/enable-bonus-imports features/enhanced-using features/extensionEverything features/fixed-buffers features/generic-attributes features/invertif features/localsinit features/nested-stackalloc features/nullable-common features/optest features/range features/razor-far features/razorFar features/records features/recursive-patterns features/ref-partial features/ref-reassignment features/remotels features/sdk2 features/source-build features/source-generators features/strongname features/target-typed-new features/unmanaged-constructed-types features/verification features/xcopy findRefsOOPWork2RPS findRefsOOPWork2 fixsigning ide-dataflow-analyzer infrastructure/optprof-validation infrastructure/optprof inject-range-indexers insertion-snapshot/20181213.1 integ ivanbasov/asynccompletion master-vs-deps master microupdate netcore2.1-preview2 new-fixed-rules patterns2 releases/Dev14CTP5 releases/Dev14CTP6 releases/Dev14Preview releases/VS2015RC releases/VS2015 revert-30093-dev15.9.x-unused-crash rls sessionBGThread15.3 simpletagnostic sourceText sqliteWork5 tmeschter/AddSatelliteAssembliesToSetup-180719 update-readme updating-publish using-var vsts-dnceng-yml_increase-timeout
Nothing to show
Commits on Dec 12, 2018
  1. close sqlite connection when solution is closed (#31687)

    heejaechang committed Dec 12, 2018
    * make sure we release lock when solution is closed by setting working folder to null
    * verify solution close removing working folder
  2. fixed re-enterance bug in async operation listener. (#31634)

    heejaechang committed Dec 12, 2018
    * fixed re-enterance bug in async operation listener.
    basically we are calling SetResult inside of a lock and since we used regular lock which allows re-enterance, we sometimes ran arbitary code under lock which re-entered async operation listener and mess everything up.
    changed to non re-enterance lock so that it explicitly throws if re-enterance happens.
    and make sure call SetResult from other thread (out side of the lock).
    * use new task creation option
    * renamed methods to have NoLock
    * updated comment
Commits on Dec 11, 2018
  1. added Telemetry dumper to roslyn diagnostic tool window (#31626)

    heejaechang committed Dec 11, 2018
    * clean up code around suggestedaction telemetry
    * added a tool in roslyn diagnostic window to dump fixer telemetry info
Commits on Dec 10, 2018
  1. added partial solution telemetry (#31478)

    heejaechang committed Dec 10, 2018
    * renamed LogSummary to ReportTelemetry
    * added telemetry to see how often partial solutoin is used
Commits on Dec 7, 2018
  1. make sure we don't load assembly too early for vsix installed analyze… (

    heejaechang committed Dec 7, 2018
    * make sure we don't load assembly too early for vsix installed analyzer dlls.
    we had special code around vsix installed analyzers dlls to make sure it doesn't get loaded until it is actually used. that got broken when I made this fix - #31438
    this puts that special behavior back to make RPS happy.
    * added a test that indirectly check the expected behavior.
    directly testing whether assembly got loaded or not is not easy to test so using indirect way
    * update comments
    * addressed feedback on cancellationtoken
    * added more comment
Commits on Dec 6, 2018
  1. support semantic errors for script files in misc projects. (#31134)

    heejaechang committed Dec 6, 2018
    * refactor and clean up diagnostic engine code so that it can be re-used stand alone.
    code refactored is related to properly set up CompilationWithAnalyzer and compute and return diagnostics
    * made default diagnostic analyzer service to share code with VS diagnostic analyzer service on computing diagnostics.
    unlike VS diagnostic analyzer, the default one doesn't persist data or calculate diagnostics per a analyzer to improve per analyzer freshes nor compute and maintain per project analyzers and etc.
    also, this add ability to calculate semantic diagnostics for script file.
    * enable semantic diagnostics for script file for misc workspace.
    now, C#/VB script files in misc workspace will get semantic errors as well as syntax errors.
    any language such as F# if document is added to misc workspace with SourceCodeKind.Script, they will automatically get semantic errors as well.
    this PR doesn't address changes propagations for #load which was never supported for existing C#/VB script support.
    * addressed PR feedbacks
Commits on Dec 5, 2018
Commits on Dec 4, 2018
  1. Set working folder for the solution added. (#31448)

    heejaechang committed Dec 4, 2018
    * Set working folder for the solution added.
    persistent service requires working folder location to find out where to save its persistent file
    * added integration test to verify working folder exist
Commits on Nov 30, 2018
  1. some code clean up and added some code instruments to make perf inves… (

    heejaechang committed Nov 30, 2018
    * some code clean up and added some code instruments to make perf investigation easier
    * changed lambda to local function and addressed feedback
  2. added unit test for analyzer checksum change (#31463)

    heejaechang committed Nov 30, 2018
Commits on Nov 29, 2018
  1. make sure to VS and OOP to use same file to get mvid of analyzer file…

    heejaechang committed Nov 29, 2018
    … reference when creating checksum for both VS and OOP (#31438)
    the problem is that the OOP always used the actual file that got used for analyzer (in other words, shadow copied file in VS), but VS used original file to get MVID.
    based on shadow copying logic, 2 (with same assembly identity) might actually be 2 different files by sharing a shadow copied file between 2 original files with same assembly identitis causing MVID to be different.
    this make sure all use same file for MVID so that regardless of host implementation of analyzer loader (who is the actual thing that control what file will be used to get analyzers), we get consistent MVID
Commits on Nov 27, 2018
  1. fixed a race where solution cralwer used wrong solution for it to pro… (

    heejaechang committed Nov 27, 2018
    * fixed a race where solution cralwer used wrong solution for it to process.
    race is this.
    1. solution crawler picked up a solution
    2. before processing the solution, workitem got changed
    3. and then picked up an work item from the queue
    4. and use the work item with the solution that got picked up in step 1
    step 2 is happening beacuse solution has changed, but step 4 used old solution from step 1
    that doesn't have effects of the solution changes.
    solution crawler must pick up solution after it has picked up work item from the queue so that new changes of a solution get enqueued as new work item,
    * Update src/Features/Core/Portable/SolutionCrawler/WorkCoordinator.NormalPriorityProcessor.cs
    thank you
    Co-Authored-By: heejaechang <>
    * addressing feedback
Commits on Nov 18, 2018
  1. enable non fatal watson (#31236)

    heejaechang committed Nov 18, 2018
Commits on Nov 17, 2018
  1. made unit test pass again with new columns in FAR

    heejaechang committed Nov 17, 2018
Commits on Nov 16, 2018
  1. fixed merge conflicts

    heejaechang committed Nov 16, 2018
Commits on Nov 15, 2018
  1. add output paths as one of causes to reanalyze solution cralwer. (#31181

    heejaechang committed Nov 15, 2018
    output paths are not specifically affecting semantics of code but some analyzer such as source based test discovery requires it to generate correct data. so they want to be re-analyzed when those are changed as well.
    since output path are rarely get changed. decide to add it as one of cause to reanalyze projects.
Commits on Nov 10, 2018
  1. put internal API partner team is using (FSharp)

    heejaechang committed Nov 9, 2018
Commits on Nov 9, 2018
  1. Add dynamic file support and hook it up to the project system

    heejaechang authored and sharwell committed Nov 9, 2018
  2. Remove unused parameter

    heejaechang authored and sharwell committed Nov 9, 2018
  3. Wrap parameter list

    heejaechang authored and sharwell committed Nov 9, 2018
  4. Remove trailing whitespace

    heejaechang authored and sharwell committed Nov 9, 2018
  5. Extract DocumentSpanExtensions to its own file

    heejaechang authored and sharwell committed Nov 9, 2018
  6. Handle errors in Inline Rename

    heejaechang authored and sharwell committed Nov 9, 2018
  7. Add IDocumentOperationService.SupportDiagnostics

    heejaechang authored and sharwell committed Oct 31, 2018
Commits on Nov 8, 2018
  1. Support document-specific services with IDocumentService

    heejaechang authored and sharwell committed Oct 31, 2018
  2. Support cloning a SourceText with a content type

    heejaechang authored and sharwell committed Oct 31, 2018
  3. fixed crash found by testing

    heejaechang committed Nov 8, 2018
    make sure commit from rename daskboard on closed razor file doesn't crash VS but show error message
  4. Adjust whitespace

    heejaechang authored and sharwell committed Oct 31, 2018
  5. Simplify auto properties

    heejaechang authored and sharwell committed Oct 31, 2018
Commits on Nov 7, 2018
  1. fixed issue we found from final val build with all razor/project syst…

    heejaechang committed Nov 7, 2018
    …em/roslyn/codelens changes.