New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in editorconfig storage location for csharp_space_around_binary_operators #20355

Closed
jnm2 opened this Issue Jun 21, 2017 · 1 comment

Comments

Projects
None yet
5 participants
@jnm2
Contributor

jnm2 commented Jun 21, 2017

I think I found a typo which looks like it will cause a bug.
Looks like it should be "csharp_space_around_binary_operators", not "csharp_space_around_binary_operators " with the extra space.

It's in master as well as in the current release version. Introduced in c0cd291.

https://github.com/dotnet/roslyn/blob/version-2.2.0/src/Workspaces/CSharp/Portable/Formatting/CSharpFormattingOptions.cs#L126

@Pilchie

This comment has been minimized.

Show comment
Hide comment
@Pilchie

Pilchie Jun 22, 2017

Member

Thanks for finding!

Member

Pilchie commented Jun 22, 2017

Thanks for finding!

@Pilchie Pilchie modified the milestones: 15.5., 15.5 Jun 22, 2017

@jinujoseph jinujoseph modified the milestones: 15.5, 15.later, 15.6, Unknown Oct 30, 2017

seangwright added a commit to seangwright/roslyn that referenced this issue Jan 28, 2018

Fix CSharpFormattingOptions csharp_space_around_binary_operators key
Fixes issue dotnet#20355?

Is there something special about this bug or am I missing something? There's just an extra space that needs removed, right?

seangwright added a commit to seangwright/roslyn that referenced this issue Feb 14, 2018

Fix CSharpFormattingOptions csharp_space_around_binary_operators key
Fixes issue dotnet#20355?

Is there something special about this bug or am I missing something? There's just an extra space that needs removed, right?

@jinujoseph jinujoseph modified the milestones: Unknown, 15.7 Feb 14, 2018

@sharwell sharwell closed this Feb 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment