Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow collapsing 'case' blocks for switch statements. #29998

Closed
CyrusNajmabadi opened this issue Sep 18, 2018 · 17 comments
Closed

Allow collapsing 'case' blocks for switch statements. #29998

CyrusNajmabadi opened this issue Sep 18, 2018 · 17 comments
Labels
Area-IDE Feature Request help wanted The issue is "up for grabs" - add a comment if you are interested in working on it
Milestone

Comments

@CyrusNajmabadi
Copy link
Member

No description provided.

@AdamSpeight2008
Copy link
Contributor

AdamSpeight2008 commented Sep 18, 2018

@CyrusNajmabadi
Just informing you that respective implementation for (Select Case blocks) are (Issue #8278, PR #27617)

@CyrusNajmabadi
Copy link
Member Author

@AdamSpeight2008 Great! Can you roll the C# side of htis into your PR as well?

@jinujoseph jinujoseph added Area-IDE Feature Request Need Design Review The end user experience design needs to be reviewed and approved. labels Sep 20, 2018
@jinujoseph jinujoseph added this to the Unknown milestone Sep 20, 2018
@jinujoseph jinujoseph added this to In Queue in IDE: Design review via automation Jun 10, 2019
@jinujoseph jinujoseph moved this from In Queue to Next meeting (priority) in IDE: Design review Jun 24, 2019
@jasonmalinowski jasonmalinowski moved this from Next meeting (priority) to Need Update in IDE: Design review Jun 24, 2019
@jinujoseph
Copy link
Contributor

Design Meeting Notes
Seems like a good idea, We should not collapse the case value itself, but anything under its body should be collapsible.
also see related issue #35792

@jinujoseph jinujoseph added help wanted The issue is "up for grabs" - add a comment if you are interested in working on it and removed Need Design Review The end user experience design needs to be reviewed and approved. labels Jul 1, 2019
@jinujoseph jinujoseph moved this from Need Update to Complete in IDE: Design review Jul 1, 2019
@kendrahavens
Copy link
Contributor

@melicaster
Copy link

Anyone working on this? I think this is a good feature to have as now I have cases that is super big.

@sharwell
Copy link
Member

sharwell commented Feb 6, 2020

@melicaster this is still up-for-grabs. Would you happen to be interested in picking it up? 😄

@AdamSpeight2008
Copy link
Contributor

@melicaster @sharwell Other than the linked pull-request in the first reply?

@jmarolf
Copy link
Contributor

jmarolf commented Feb 7, 2020

@AdamSpeight2008 I believe you closed that PR, do you still want to work on this?

@AdamSpeight2008
Copy link
Contributor

@jmarolf To honest I couldn't care less about who implements it, it was I (and the community) have wanted. So I implemented a version. Who implements "the version" don't care.

@CyrusNajmabadi
Copy link
Member Author

@AdamSpeight2008 would you be willing to complete that original PR? Someone else could potentially do the C# side (or you could do it if interested). Thanks!

@CyrusNajmabadi
Copy link
Member Author

@AdamSpeight2008 can you let us know what your plans are here? thanks!

@AdamSpeight2008
Copy link
Contributor

@CyrusNajmabadi It was completed 4 years ago, I moved on.
You are someone else can rebase the pull request on the latest branch.

@ptuga
Copy link

ptuga commented Dec 5, 2022

Hello arkalyanms,

What does this mean?
I'm sorry but I don't understand. I've raised an issue with Microsoft and ended here.
Was the interface changed between 2017 and twas this feature removed in 2020?
I don't see any advantage removing the collapse symbols inside each case statement.

Please advise.
Many thanks.

Kind regards,
ptuga

@AdamSpeight2008
Copy link
Contributor

@ptuga The interface did not change, but the coding to enable that collapsing of inner symbols (not just case statements) was provided in pull request #27617

@ptuga
Copy link

ptuga commented Dec 13, 2022

@AdamSpeight2008 Hello, sorry for my ignorance on the topic. I'm new on this environment. The pull request 27617 has comments going back to Oct 31, 2018. Does this means the coding to enable the function I reported has been implemented or will be implemented at some point in the future (is it possible to know when)? As far I can experience, this isn't available in Microsoft Visual Studio Community 2022 (64-bit) - Current Version 17.4.1. Could you please clarify? Thank you

@CyrusNajmabadi
Copy link
Member Author

@ptuga Taht PR was abandoned. No work has been done since to enable this feature. We would likely accept a PR from Adam (or you) on this topic if either of you are interested. Thanks!

@CyrusNajmabadi
Copy link
Member Author

Fixed with #66724.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Feature Request help wanted The issue is "up for grabs" - add a comment if you are interested in working on it
Projects
Archived in project
IDE: Design review
  
Complete
Development

No branches or pull requests

8 participants