New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider persisting wrapping MRU values across sessions. #31577

Open
CyrusNajmabadi opened this Issue Dec 6, 2018 · 1 comment

Comments

3 participants
@CyrusNajmabadi
Contributor

CyrusNajmabadi commented Dec 6, 2018

See #30422 (comment) for more details.

@vatsalyaagrawal vatsalyaagrawal added this to the 16.0 milestone Dec 6, 2018

@vatsalyaagrawal vatsalyaagrawal added this to In Queue in IDE: Design review via automation Dec 6, 2018

@sharwell sharwell moved this from In Queue to Next meeting (priority) in IDE: Design review Dec 10, 2018

@sharwell sharwell moved this from Next meeting (priority) to Need Update in IDE: Design review Dec 10, 2018

@sharwell

This comment has been minimized.

Member

sharwell commented Dec 11, 2018

We discussed this in a design review yesterday, and felt that the MRU used by this feature is likely a side effect of one of the following:

  1. Inability to provide options to code refactorings (e.g. a user might want one of the refactoring operations deprioritized because it fails to meet a required coding style for the project, but an option to disable that part of the refactoring might be better than a persisted MRU)
  2. Lack of a "smarter" code fix/suggestion prioritization mechanism at a larger scale (e.g. the MRU could be provided by the underlying Light Bulb feature in some manner, and persisted there instead of persisting it once for each option)

For now we'll close this issue as Won't Fix, which avoids some hard questions related to versioning and cross-IDE experiences.

@sharwell sharwell moved this from Need Update to Complete in IDE: Design review Dec 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment