Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Regression] Completion gets in the way attempting to line up arguments #34237

Closed
davkean opened this Issue Mar 19, 2019 · 2 comments

Comments

@davkean
Copy link
Member

davkean commented Mar 19, 2019

This is a regression from Version 15.9.9.

Version Used:
Version 16.0.0 Preview 4.2 [28711.60.d16.0]

Steps to Reproduce:

At $, press ENTER and then TAB:

String.Equals("foo", "bar", $StringComparison.CurrentCulture)

Expected (15.9):

String.Equals("foo", "bar", 
        StringComparison.CurrentCulture)

Actual (16.0):

String.Equals("foo", "bar", 
    StringComparisonStringComparison.CurrentCulture)

Here's a video of it:

Completion3

@sharwell

This comment has been minimized.

Copy link
Member

sharwell commented Mar 19, 2019

@ivanbasov is Enter ever a completion trigger prior to 16.0? Can you describe the impacted scenarios?

@dpoeschl

This comment has been minimized.

Copy link
Member

dpoeschl commented Mar 19, 2019

Note: This only seems to happen when the corresponding parameter is of an enum type.

@ivanbasov ivanbasov self-assigned this Mar 19, 2019

@ivanbasov ivanbasov added this to Awaiting Triage in Editor Completion via automation Mar 19, 2019

@ivanbasov ivanbasov added this to the 16.1 milestone Mar 19, 2019

@jinujoseph jinujoseph modified the milestones: 16.1, 16.1.P1 Mar 20, 2019

Editor Completion automation moved this from Awaiting Triage to Completed Mar 26, 2019

@ivanbasov ivanbasov modified the milestones: 16.1.P1, 16.1.P2 Mar 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.