Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion sugests items that do not satisfy generic constraint #39689

Open
pakrym opened this issue Nov 5, 2019 · 4 comments
Open

Completion sugests items that do not satisfy generic constraint #39689

pakrym opened this issue Nov 5, 2019 · 4 comments

Comments

@pakrym
Copy link

@pakrym pakrym commented Nov 5, 2019

Version Used: Version 16.5.0 Preview 1.0 [29501.166.master]

Steps to Reproduce:

  1. Create Console app
  2. Add Azure.Storage.Blobs Nuget package
  3. Open intellisense on args.

Expected Behavior:

Extension methods that don't satisfy the generic constraint are not shown.

Actual Behavior:

AddBlobServiceClient is shown

image

        /// <summary>
        /// Registers a <see cref="BlobServiceClient"/> instance with connection options loaded from the provided <paramref name="configuration"/> instance.
        /// </summary>
        public static IAzureClientBuilder<BlobServiceClient, BlobClientOptions> AddBlobServiceClient<TBuilder, TConfiguration>(this TBuilder builder, TConfiguration configuration)
            where TBuilder : IAzureClientFactoryBuilderWithConfiguration<TConfiguration>
        {
            return builder.RegisterClientFactory<BlobServiceClient, BlobClientOptions>(configuration);
        }
@Dreamescaper

This comment has been minimized.

Copy link
Contributor

@Dreamescaper Dreamescaper commented Nov 5, 2019

That does not look like native VS IntelliSense. Is that Resharper?

@pakrym

This comment has been minimized.

Copy link
Author

@pakrym pakrym commented Nov 5, 2019

My bad, reproes with R# disabled:

image

@sharwell

This comment has been minimized.

Copy link
Member

@sharwell sharwell commented Nov 5, 2019

@ivanbasov This sounds like #37780 but was reported on 16.5 internal preview.

@ivanbasov

This comment has been minimized.

Copy link
Contributor

@ivanbasov ivanbasov commented Nov 5, 2019

@gafter this maybe related with #38109 . Maybe more work should be done on the compiler side. Please take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.