Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename does not work for C# class name in VS 17.9.6 #73582

Closed
vsfeedback opened this issue May 20, 2024 · 2 comments
Closed

Rename does not work for C# class name in VS 17.9.6 #73582

vsfeedback opened this issue May 20, 2024 · 2 comments
Assignees

Comments

@vsfeedback
Copy link

This issue has been moved from a ticket on Developer Community.


[severity:It's more difficult to complete my work] [regression] [worked-in:Maybe 17.5]

  1. Open C# project

  2. Open any .cs file, which declares a class

  3. Select class name and press Ctrl+r+r

  4. Enter new class name and press Enter
    Observed: class is not renamed and empty line is added below class name.

  5. Select class name and press Ctrl+r+r

  6. Enter new class name and press Shift+Enter
    Observed: preview shows up and 2 exceptions are also reported.

  7. Click Apply
    Observed: class is not renamed and empty line is added below class name.

Exceptions reported at step 5:
StreamJsonRpc.RemoteInvocationException: Unexpected false - line 517
at StreamJsonRpc.JsonRpc.d__1511.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.CodeAnalysis.Remote.BrokeredServiceConnection1.d__201.MoveNext() RPC server exception: System.InvalidOperationException: Unexpected false - line 517 at Roslyn.Utilities.Contract.Fail(String message, Int32 lineNumber) at Microsoft.CodeAnalysis.Remote.RemoteWorkspace.SolutionCreator.UpdateDocumentInfoAsync(TextDocument document, Checksum infoChecksum, CancellationToken cancellationToken) at Microsoft.CodeAnalysis.Remote.RemoteWorkspace.SolutionCreator.UpdateDocumentAsync(TextDocument document, DocumentStateChecksums oldDocumentChecksums, DocumentStateChecksums newDocumentChecksums, CancellationToken cancellationToken) at Microsoft.CodeAnalysis.Remote.RemoteWorkspace.SolutionCreator.UpdateDocumentsAsync[TDocumentState](Project project, ProjectStateChecksums projectChecksums, TextDocumentStates1 existingTextDocumentStates, ChecksumsAndIds1 oldChecksums, ChecksumsAndIds1 newChecksums, Func3 addDocuments, Func3 removeDocuments, CancellationToken cancellationToken)
at Microsoft.CodeAnalysis.Remote.RemoteWorkspace.SolutionCreator.UpdateProjectAsync(Project project, ProjectStateChecksums oldProjectChecksums, ProjectStateChecksums newProjectChecksums, CancellationToken cancellationToken)
at Microsoft.CodeAnalysis.Remote.RemoteWorkspace.SolutionCreator.UpdateProjectsAsync(Solution solution, SolutionStateChecksums oldSolutionChecksums, SolutionStateChecksums newSolutionChecksums, CancellationToken cancellationToken)
at Microsoft.CodeAnalysis.Remote.RemoteWorkspace.SolutionCreator.CreateSolutionAsync(Checksum newSolutionChecksum, CancellationToken cancellationToken)
at Microsoft.CodeAnalysis.Remote.RemoteWorkspace.ComputeDisconnectedSolutionAsync(AssetProvider assetProvider, Checksum solutionChecksum, CancellationToken cancellationToken)
at Microsoft.CodeAnalysis.Remote.RemoteWorkspace.<>c__DisplayClass21_1.<<GetOrCreateSolutionAndAddInFlightCount_NoLock>b__2>d.MoveNext()
--- End of stack trace from previous location ---
at Microsoft.VisualStudio.Threading.ThreadingTools.WithCancellationSlow[T](Task1 task, CancellationToken cancellationToken) at Microsoft.CodeAnalysis.Remote.RemoteWorkspace.<>c__DisplayClass9_01.<g__ProcessSolutionAsync|1>d.MoveNext()
--- End of stack trace from previous location ---
at Microsoft.CodeAnalysis.Remote.RemoteWorkspace.RunWithSolutionAsync[T](AssetProvider assetProvider, Checksum solutionChecksum, Int32 workspaceVersion, Boolean updatePrimaryBranch, Func2 implementation, CancellationToken cancellationToken) at Microsoft.CodeAnalysis.Remote.RemoteWorkspace.RunWithSolutionAsync[T](AssetProvider assetProvider, Checksum solutionChecksum, Int32 workspaceVersion, Boolean updatePrimaryBranch, Func2 implementation, CancellationToken cancellationToken)
at Microsoft.CodeAnalysis.Remote.BrokeredServiceBase.RunWithSolutionAsync[T](Checksum solutionChecksum, Func2 implementation, CancellationToken cancellationToken) at Microsoft.CodeAnalysis.Remote.BrokeredServiceBase.RunServiceImplAsync[T](Func2 implementation, CancellationToken cancellationToken)


Original Comments

Feedback Bot on 5/8/2024, 08:50 PM:

(private comment, text removed)


Original Solutions

(no solutions)

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels May 20, 2024
@genlu genlu added Bug and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 5, 2024
@genlu
Copy link
Member

genlu commented Jun 5, 2024

FYI @CyrusNajmabadi there's an exception during solution syncing

@CyrusNajmabadi
Copy link
Member

I'm closing this out. This was against 17.9, and we've written these parts entirely since then. I don't see a similar issue in prism for later builds.

@CyrusNajmabadi CyrusNajmabadi closed this as not planned Won't fix, can't repro, duplicate, stale Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants