New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate expression-bodies ctor, dtor, and property accessors into master #13970

Merged
merged 9 commits into from Sep 24, 2016

Conversation

@gafter
Member

gafter commented Sep 22, 2016

This code has previously been reviewed before going into the feature branch. There are no outstanding issues, so I propose to integrate this into master.

@dotnet/roslyn-compiler @jaredpar Please review for final integration. I don't expect a full code review is required.

@gafter

This comment has been minimized.

Show comment
Hide comment
@gafter

gafter Sep 22, 2016

Member

@jaredpar Are you OK with this being merged?

Member

gafter commented Sep 22, 2016

@jaredpar Are you OK with this being merged?

@gafter

This comment has been minimized.

Show comment
Hide comment
@gafter

gafter Sep 24, 2016

Member

@lachbaer Thank you so much for this work! It is going into C# 7.

Member

gafter commented Sep 24, 2016

@lachbaer Thank you so much for this work! It is going into C# 7.

@gafter gafter merged commit ed48bb9 into master Sep 24, 2016

8 checks passed

linux_debug_prtest Build finished.
Details
microbuild_prtest Build finished.
Details
perf_correctness_prtest Build finished.
Details
windows_debug_unit32_prtest Build finished.
Details
windows_debug_unit64_prtest Build finished.
Details
windows_eta_open_prtest Build finished.
Details
windows_release_unit32_prtest Build finished.
Details
windows_release_unit64_prtest Build finished.
Details
@lachbaer

This comment has been minimized.

Show comment
Hide comment
@lachbaer

lachbaer Sep 24, 2016

Contributor

@gafter Thank you very much for letting me be a part of this project! :-)

Contributor

lachbaer commented Sep 24, 2016

@gafter Thank you very much for letting me be a part of this project! :-)

@jaredpar jaredpar deleted the features/exprbody branch Feb 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment