New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated WorkItemAttribute documentation #18403

Merged
merged 2 commits into from Jul 6, 2017

Conversation

Projects
None yet
5 participants
@sharwell
Member

sharwell commented Apr 3, 2017

The construction arguments were misleading with respect to our practices. I
updated the names and documentation so new contributors can follow along more
easily.

@Pilchie

Pilchie approved these changes Apr 3, 2017

@sharwell

This comment has been minimized.

Show comment
Hide comment
@sharwell

sharwell Apr 3, 2017

Member

😆 I had no idea that this change would result in the build system enforcing that the location is a URI.

Member

sharwell commented Apr 3, 2017

😆 I had no idea that this change would result in the build system enforcing that the location is a URI.

@Pilchie

This comment has been minimized.

Show comment
Hide comment
@MaximRouiller

This comment has been minimized.

Show comment
Hide comment
@MaximRouiller

MaximRouiller Apr 4, 2017

Contributor

😛 Sorry about that. 🇨🇦

Contributor

MaximRouiller commented Apr 4, 2017

😛 Sorry about that. 🇨🇦

@sharwell

This comment has been minimized.

Show comment
Hide comment
@sharwell

sharwell Apr 5, 2017

Member

@MaximRouiller It's not a bad thing. 😄 It's not too often we get someone who provides as complete a picture of their onboarding experience as you did (between the work in the issue/PR and the blog posts).

I'm planning to fix up all the prior deviations during the week of 4/17 and merge this afterwards.

Member

sharwell commented Apr 5, 2017

@MaximRouiller It's not a bad thing. 😄 It's not too often we get someone who provides as complete a picture of their onboarding experience as you did (between the work in the issue/PR and the blog posts).

I'm planning to fix up all the prior deviations during the week of 4/17 and merge this afterwards.

@MaximRouiller

This comment has been minimized.

Show comment
Hide comment
@MaximRouiller

MaximRouiller Apr 5, 2017

Contributor

@sharwell One thing for sure... traffic on my post has been exploding. If there is anything more I can document in this way, please let me know. It's literally a win-win-win scenario (user/me/Microsoft).

Contributor

MaximRouiller commented Apr 5, 2017

@sharwell One thing for sure... traffic on my post has been exploding. If there is anything more I can document in this way, please let me know. It's literally a win-win-win scenario (user/me/Microsoft).

sharwell added some commits Apr 3, 2017

Updated WorkItemAttribute documentation
The construction arguments were misleading with respect to our practices. I
updated the names and documentation so new contributors can follow along more
easily.

@sharwell sharwell merged commit 2f1fa44 into dotnet:master Jul 6, 2017

13 checks passed

microbuild_prtest Build finished.
Details
perf_correctness_prtest Build finished.
Details
ubuntu_14_debug_prtest Build finished.
Details
ubuntu_16_debug_prtest Build finished.
Details
windows_build_correctness_prtest Build finished.
Details
windows_coreclr_test_prtest Build finished.
Details
windows_debug_unit32_prtest Build finished.
Details
windows_debug_unit64_prtest Build finished.
Details
windows_debug_vs-integration_prtest Build finished.
Details
windows_determinism_prtest Build finished.
Details
windows_release_unit32_prtest Build finished.
Details
windows_release_unit64_prtest Build finished.
Details
windows_release_vs-integration_prtest Build finished.
Details

@sharwell sharwell deleted the sharwell:workitem-doc branch Jul 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment