Implementation of new editor completion API by ivanbasov · Pull Request #29016 · dotnet/roslyn

ivanbasov · 2018-08-01T22:51:57Z

No description provided.

tmat · 2018-08-04T19:12:54Z

What is the relationship of this PR to #25770? What's new here? #Resolved

sharwell

Marking as request changes for the sole purpose of making sure I don't forget to review this one.

ivanbasov · 2018-08-06T18:14:10Z

@tmat , this is a merge of #25770 with recent biths of master-vs-deps. I'll close #25770 as soon as I'll merge this one and migrate another PR depending on #25770 to new master-bs-deps bits.

@sharwell , an interesting approach to make notes :-) So, could you please review?

@jasonmalinowski , @jinujoseph, @dotnet/roslyn-ide , pinging ... do we have reasons to keep this work pending for a long time once again? #Resolved

jasonmalinowski

Comments so far. I still need to review EditorAsyncCompletionItemManager.cs.

The custom commit code to me is particularly worrisome -- at first glance it has a number of bugs around handling of snapshots. If it's right I'd appreciate a lot more comments as to why it's right.

For the tests, I think we should figure out a better way to share the test assets rather than a copy/paste. xunit allows (among other things) you to use inherited test classes to try running the same tests with some different context. It might require a bit of adding a layer of indirection, but I think it'll make it a lot easier to understand this PR and maintain this code even in the short term. I'm guessing we won't be deprecating the old one for a few previews, and in that time we might have other work to be doing for language support.

jasonmalinowski · 2018-08-08T01:03:45Z

Makes sense to me. Why the bug? #Resolved

jasonmalinowski · 2018-08-08T01:05:48Z

Isn't this all just triggerBuffer.CurrentSnapshot.GetDocumentInCurrentContext()? #WontFix

Could not find GetDocumentInCurrentContext in CurrentSnapshot

In reply to: 208429747 [](ancestors = 208429747)

jasonmalinowski · 2018-08-08T01:06:26Z

Same as next function below? Can we reuse? #Resolved

The method just below is unused. Removing it. :-)

In reply to: 208429831 [](ancestors = 208429831)

jasonmalinowski · 2018-08-08T01:06:38Z

What should we be doing here? Anything? #Resolved

jasonmalinowski · 2018-08-08T01:09:25Z

Constant since I'm guessing this is hardcoded in other places? #Resolved

the only other instance is in test state. so, it think constant is not necessary.

In reply to: 208430212 [](ancestors = 208430212)

@ivanbasov Still having a constant would mean that's possible to determine. #Resolved

sharwell

This pull request should not be merged until we fix the rename tracking for items in the OldCompletion folder. I implemented the change locally and am working with @ivanbasov to correct the pull request.

sharwell · 2018-08-08T15:06:27Z

@ivanbasov I figured out the file copy tracking, but it's not the most pleasant thing ever. This pull request is blocked on #29166; after that is merged I'll update this pull request and it will be much better. #Resolved

jasonmalinowski · 2018-08-08T19:37:09Z

Should the editor provide a FilteredCompletionModel.Empty? #Pending

@amwieczo@microsoft.com please take a look

In reply to: 208708360 [](ancestors = 208708360)

jasonmalinowski · 2018-08-08T19:38:17Z

.SelectedFilters isn't the filters that are selected? @AmadeusW? #Resolved

This is complete set of filters, specifically CompletionFilterWithStates. I see how "SelectedFilters" is a poor name for "all filters"

Each element of this enumeration has a reference to the CompletionFilter and two bools: IsAvailable and IsSelected

Language service is expected to

Filter the completion items based on typed text,
which determines the IsAvailable property (true if at least one completion item of that filter is present)

Filter the results based on filter's IsSelected property (value is set by user) #Resolved

So are we renaming this? 😄 #Resolved

Yes, copying the original response by @amwieczo@microsoft.com

This is complete set of filters, specifically CompletionFilterWithStates. I see how "SelectedFilters" is a poor name for "all filters"

Each element of this enumeration has a reference to the CompletionFilter and two bools: IsAvailable and IsSelected

Language service is expected to

Filter the completion items based on typed text,
which determines the IsAvailable property (true if at least one completion item of that filter is present)

Filter the results based on filter's IsSelected property (value is set by user)

In reply to: 208708695 [](ancestors = 208708695)

yes, here are our selectedFilters. And there are Editor's selected filters which are all filters. ugh

In reply to: 221393614 [](ancestors = 221393614)

jasonmalinowski · 2018-08-08T19:39:30Z

Do this check first before MatchesFilterText since it's a lot cheaper? #ByDesign

It seems that MatchFilterText should have another priority over the reasons comparison: if there is a Match, we set matchedFilterText: true even if it is the deletion. So, we cannot swap condition checks.

In reply to: 208709031 [](ancestors = 208709031)

CyrusNajmabadi · 2018-08-10T21:11:38Z

Can there be a general 'ping' when this is ready for reviewing? #Resolved

ivanbasov · 2018-08-11T00:46:40Z

Thank you, @CyrusNajmabadi! Will do

In reply to: 412207683 [](ancestors = 412207683)

dpoeschl

This shouldn't go in until the master-vs-deps --> master merge goes through.

…e with no call to get

jasonmalinowski

Looks good enough for an initial merge, with the understanding we still have a lot to clean up. A few last questions, but I don't think that'll result in any changes needed at this point.

I am still very concerned about the editor API's design around us having to be responsible for filtering and sorting other items that aren't our own in the projection case. It seems like that's still going to require some redesigns, but that's not really a problem with this PR per se but rather something they'll need to address.

jasonmalinowski · 2018-11-27T02:01:29Z

                if (change.NewPosition.HasValue)
                {
-                    view.TryMoveCaretToAndEnsureVisible(new SnapshotPoint(updatedCurrentSnapshot, change.NewPosition.Value));
+                    view.TryMoveCaretToAndEnsureVisible(new SnapshotPoint(subjectBuffer.CurrentSnapshot, change.NewPosition.Value));


Shouldn't this also be making a snapshot point against the appropriate snapshot and translating it forward? i.e. the updatedCurrentSnapshot was correct here but not further below? (This also presumes TryMoveCaretAndEnsureVisible translates forward instead of crashing.) #Resolved

Let us consider this as a separate issue: #31383

In reply to: 236495952 [](ancestors = 236495952)

jasonmalinowski · 2018-11-27T02:10:04Z

+            {
+                // Need the trigger snapshot to calculate the span when the commit changes to be applied.
+                // It should be inserted into a property bag within GetCompletionContextAsync for each item created by Roslyn.
+                // If not found here, Roslyn should not make a commit.


How would we get here in the first place? You already filtered non-Roslyn items earlier? #Resolved

We can miss to provide triggerSnapshot by mistake.

Let us assume there is another provider wants Roslyn to perform a commit and provided CompletionSource.RoslynItem above. We can proceed but we also need triggerSnapshot in the case.

In reply to: 236497307 [](ancestors = 236497307)

jasonmalinowski · 2018-11-27T02:10:30Z

+                return CommitResultUnhandled;
+            }
+
+            // Commit with completion serivce assumes that null is provided is case of invoke. VS provides '\0' in the case.


Suggested change

// Commit with completion serivce assumes that null is provided is case of invoke. VS provides '\0' in the case.

// Commit with completion service assumes that null is provided is case of invoke. VS provides '\0' in the case.

``` #Resolved

jasonmalinowski · 2018-11-27T02:13:37Z

+            if (textTypedSoFar.Length > 0)
+            {
+                return item.DisplayText.StartsWith(textTypedSoFar, StringComparison.CurrentCultureIgnoreCase) ||
+                       item.FilterText.StartsWith(textTypedSoFar, StringComparison.CurrentCultureIgnoreCase);


Didn't we also do filtering explicitly in en-us for people using non-English things trying to type English framework names? #Resolved

#31384

In reply to: 236497871 [](ancestors = 236497871)

CyrusNajmabadi · 2018-11-27T03:38:23Z

I am still very concerned about the editor API's design around us having to be responsible for filtering and sorting other items that aren't our own in the projection case. It seems like that's still going to require some redesigns, but that's not really a problem with this PR per se but rather something they'll need to address.

Agreed. In the meantime though, would it be better for us to not filter/sort these items?

I ask because otherwise we know how this will likely pan out. We'll have the code for it, dependencies will be taken on it, and it will taken 15+ years to finally get removed. :)

Basically, if this is merged in, i put odds at 99% that it never ever gets removed. But if we don't add it, it will force the issue of implementing things in a proper fashion. Thoughts @jasonmalinowski

ivanbasov requested review from dpoeschl, jasonmalinowski and jinujoseph August 1, 2018 22:51

ivanbasov requested review from a team as code owners August 1, 2018 22:51

ivanbasov removed the request for review from a team August 1, 2018 22:52

ivanbasov added this to the 16.0 milestone Aug 1, 2018

ivanbasov added the Area-IDE label Aug 1, 2018

sharwell suggested changes Aug 5, 2018

View reviewed changes

sharwell reviewed Aug 6, 2018

View reviewed changes

ivanbasov mentioned this pull request Aug 8, 2018

Implementation of new editor completion API #25770

Closed

jasonmalinowski reviewed Aug 8, 2018

View reviewed changes

sharwell force-pushed the asynccompletion branch from d25db1a to 8b0988d Compare August 8, 2018 14:11

sharwell suggested changes Aug 8, 2018

View reviewed changes

sharwell mentioned this pull request Aug 8, 2018

Fork completion tests #29166

Closed

jasonmalinowski reviewed Aug 8, 2018

View reviewed changes

Comment thread ...plementation/IntelliSense/EditorCompletionImplementation/EditorAsyncCompletionItemManager.cs Outdated

jasonmalinowski reviewed Aug 8, 2018

View reviewed changes

ivanbasov force-pushed the asynccompletion branch from 29d5f57 to 54c1e92 Compare August 9, 2018 20:53

ivanbasov added the PR For Personal Review Only The PR doesn’t require anyone other than the developer to review it. label Aug 9, 2018

ivanbasov requested a review from a team as a code owner August 10, 2018 20:48

ivanbasov force-pushed the asynccompletion branch from e78363e to e57a325 Compare August 10, 2018 20:50

ivanbasov mentioned this pull request Aug 10, 2018

Async completion bug fixes #28219

Closed

dpoeschl previously requested changes Sep 4, 2018

View reviewed changes

ivanbasov added 20 commits November 26, 2018 14:24

addressing feedback

7d15bf4

cleanup. couple non-blocking tests

fe52787

more fixes

c686d89

supporting filterchange

52a93d7

excluded commit characters

26ee32c

more fixes

7b841a2

fixed. introducing mockcompletionpresenter

bb22c5d

more fixes

2aff6a2

more fixes

3eed439

code review feedback processed

f4e892a

using options, default characters and fixing issue with calling updat…

64dac63

…e with no call to get

update must support calls without getcompletioncontext

0d1fdb4

support displayTextSuffix

520d1de

VSSDK update. Review feedback processed

1a87227

most of code review feedback processed

3cb9024

feedback processed

378a802

fixing unit test

8b7073f

feedback processed

b8c4441

skipping mono test

2a25075

code review feedback

85273b2

ivanbasov force-pushed the asynccompletion branch from 6c94b68 to 85273b2 Compare November 26, 2018 22:39

ivanbasov added 2 commits November 26, 2018 16:40

fixing unit test

2644710

fixing sharing RecentItemsManager

da9e8a0

jasonmalinowski approved these changes Nov 27, 2018

View reviewed changes

typo

44ea64e

jinujoseph added the Approved to merge label Nov 27, 2018

ivanbasov merged commit af42e74 into dotnet:master-vs-deps Nov 27, 2018

ivanbasov deleted the asynccompletion branch November 27, 2018 05:08

xoofx pushed a commit to stark-lang/stark-roslyn that referenced this pull request Apr 16, 2019

Implementation of new editor completion API (dotnet#29016)

a4a1a78

	// Commit with completion serivce assumes that null is provided is case of invoke. VS provides '\0' in the case.
	// Commit with completion service assumes that null is provided is case of invoke. VS provides '\0' in the case.
	``` #Resolved

Conversation

ivanbasov commented Aug 1, 2018

Uh oh!

tmat commented Aug 4, 2018 • edited by ivanbasov Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sharwell left a comment

Choose a reason for hiding this comment

Uh oh!

ivanbasov commented Aug 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jasonmalinowski left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jasonmalinowski Aug 8, 2018 • edited by ivanbasov Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jasonmalinowski Aug 8, 2018 • edited by ivanbasov Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jasonmalinowski Aug 8, 2018 • edited by ivanbasov Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jasonmalinowski Aug 8, 2018 • edited by ivanbasov Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jasonmalinowski Aug 8, 2018 • edited by ivanbasov Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jasonmalinowski Sep 28, 2018 • edited by ivanbasov Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sharwell left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sharwell commented Aug 8, 2018 • edited by ivanbasov Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

jasonmalinowski Aug 8, 2018 • edited by ivanbasov Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jasonmalinowski Aug 8, 2018 • edited by ivanbasov Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tmat commented Aug 4, 2018 •

edited by ivanbasov

Loading

ivanbasov commented Aug 6, 2018 •

edited

Loading

jasonmalinowski Aug 8, 2018 •

edited by ivanbasov

Loading

jasonmalinowski Aug 8, 2018 •

edited by ivanbasov

Loading

jasonmalinowski Aug 8, 2018 •

edited by ivanbasov

Loading

jasonmalinowski Aug 8, 2018 •

edited by ivanbasov

Loading

jasonmalinowski Aug 8, 2018 •

edited by ivanbasov

Loading

jasonmalinowski Sep 28, 2018 •

edited by ivanbasov

Loading

sharwell commented Aug 8, 2018 •

edited by ivanbasov

Loading

jasonmalinowski Aug 8, 2018 •

edited by ivanbasov

Loading

jasonmalinowski Aug 8, 2018 •

edited by ivanbasov

Loading

AmadeusW Aug 13, 2018 •

edited by ivanbasov

Loading

jasonmalinowski Sep 28, 2018 •

edited by ivanbasov

Loading

jasonmalinowski Aug 8, 2018 •

edited by ivanbasov

Loading

CyrusNajmabadi commented Aug 10, 2018 •

edited by ivanbasov

Loading

jasonmalinowski Nov 27, 2018 •

edited by ivanbasov

Loading

jasonmalinowski Nov 27, 2018 •

edited by ivanbasov

Loading

jasonmalinowski Nov 27, 2018 •

edited by ivanbasov

Loading

jasonmalinowski Nov 27, 2018 •

edited by ivanbasov

Loading