New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not eliminate conditional branch if it falls through to a different exception handler. #29517

Merged
merged 1 commit into from Sep 5, 2018

Conversation

Projects
None yet
4 participants
@AlekseyTs
Contributor

AlekseyTs commented Aug 24, 2018

Fixes #29481.

@AlekseyTs AlekseyTs requested a review from dotnet/roslyn-compiler as a code owner Aug 24, 2018

@AlekseyTs

This comment has been minimized.

Show comment
Hide comment
@AlekseyTs
Contributor

AlekseyTs commented Aug 27, 2018

@jcouv

jcouv approved these changes Aug 27, 2018

LGTM Thanks (iteration 1)

@jcouv jcouv self-assigned this Aug 27, 2018

@AlekseyTs

This comment has been minimized.

Show comment
Hide comment
@AlekseyTs

AlekseyTs Aug 28, 2018

Contributor

@dotnet/roslyn-compiler Please review, need second sign-off.

Contributor

AlekseyTs commented Aug 28, 2018

@dotnet/roslyn-compiler Please review, need second sign-off.

@AlekseyTs

This comment has been minimized.

Show comment
Hide comment
@AlekseyTs

AlekseyTs Aug 28, 2018

Contributor

@VSadov Please review.

Contributor

AlekseyTs commented Aug 28, 2018

@VSadov Please review.

@VSadov

VSadov approved these changes Aug 29, 2018

LGTM

@AlekseyTs

This comment has been minimized.

Show comment
Hide comment
@AlekseyTs

AlekseyTs Aug 29, 2018

Contributor

@dotnet/roslyn-compiler Please review, need a second sign-off.

Contributor

AlekseyTs commented Aug 29, 2018

@dotnet/roslyn-compiler Please review, need a second sign-off.

@AlekseyTs AlekseyTs merged commit 7ced42b into dotnet:dev15.9.x Sep 5, 2018

14 of 16 checks passed

windows_debug_vs-integration_prtest Build finished.
Details
windows_release_vs-integration_prtest Build finished.
Details
WIP ready for review
Details
license/cla All CLA requirements met.
Details
microbuild_prtest Build finished.
Details
ubuntu_16_debug_prtest Build finished.
Details
ubuntu_16_mono_debug_prtest Build finished.
Details
windows_build_correctness_prtest Build finished.
Details
windows_coreclr_debug_prtest Build finished.
Details
windows_coreclr_release_prtest Build finished.
Details
windows_debug_spanish_unit32_prtest Build finished.
Details
windows_debug_unit32_prtest Build finished.
Details
windows_debug_unit64_prtest Build finished.
Details
windows_determinism_prtest Build finished.
Details
windows_release_unit32_prtest Build finished.
Details
windows_release_unit64_prtest Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment