New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build script cleanup #30345

Merged
merged 18 commits into from Oct 10, 2018

Conversation

Projects
None yet
3 participants
@tmat
Member

tmat commented Oct 5, 2018

  • Move Linux build logic to build\scripts\build.sh
  • Eliminate MicroBuild scripts

@tmat tmat requested a review from dotnet/roslyn-infrastructure as a code owner Oct 5, 2018

@tmat tmat requested a review from dotnet/roslyn-compiler as a code owner Oct 8, 2018

@tmat tmat changed the title from WIP: Build script cleanup to Build script cleanup Oct 9, 2018

@tmat

This comment has been minimized.

Member

tmat commented Oct 9, 2018

@jaredpar PTAL

@@ -46,20 +46,19 @@ param (
# Special test options
[switch]$testDeterminism = $false,
[parameter(ValueFromRemainingArguments=$true)] $badArgs)
[parameter(ValueFromRemainingArguments=$true)][String[]]$properties)

This comment has been minimized.

@jaredpar

jaredpar Oct 9, 2018

Member

lower case string

This comment has been minimized.

@tmat

tmat Oct 9, 2018

Member

Fixed.

@@ -16,9 +16,10 @@
[CmdletBinding(PositionalBinding=$false)]
param (
[string]$configuration = "Debug",

This comment has been minimized.

@jaredpar

jaredpar Oct 9, 2018

Member

Is this just reflecting the arcade model?

This comment has been minimized.

@tmat

tmat Oct 9, 2018

Member

Yes. I was thinking we could keep -release as well, if that's more convenient. On the other hand PowerShell allows to shorten and use e.g. -con Release, so perhaps it's not necessary. I don't think IDE devs are using release builds that often. Let me know if this is common pattern for compiler devs that we should keep a short command for.

This comment has been minimized.

@jaredpar

jaredpar Oct 9, 2018

Member

I don't think anyone uses it enough that it's worth keeping if arcade does it differently.

This comment has been minimized.

@sharwell

sharwell Oct 10, 2018

Member

:(

But I can find another way.

if ($cibuild) {
# Symbol Uploader currently reports a warning for some files (https://github.com/dotnet/symstore/issues/76)
Run-MSBuild "build\Targets\RepoToolset\Publish.proj" "/t:Publish" -warnAsError:$false

This comment has been minimized.

@jaredpar

jaredpar Oct 9, 2018

Member

Why do we want to be publishing during a PR?

This comment has been minimized.

@tmat

tmat Oct 9, 2018

Member

For validation (Dry Run) of the symbol uploader.

@tmat

This comment has been minimized.

Member

tmat commented Oct 9, 2018

test ci please

@tmat

This comment has been minimized.

Member

tmat commented Oct 10, 2018

test ci please

@tmat

This comment has been minimized.

Member

tmat commented Oct 10, 2018

test this please

@tmat

This comment has been minimized.

Member

tmat commented Oct 10, 2018

test ci please

@tmat tmat closed this Oct 10, 2018

@tmat tmat reopened this Oct 10, 2018

@jaredpar

This comment has been minimized.

Member

jaredpar commented Oct 10, 2018

FYI: test ci doesn't do any work now that we are on ADO. Need to manually requeue jobs via the UI.

@tmat

This comment has been minimized.

Member

tmat commented Oct 10, 2018

It does not affect Jenkins either?

@tmat

This comment has been minimized.

Member

tmat commented Oct 10, 2018

ok, that's what i expected.

@tmat tmat changed the title from Build script cleanup to WIP: Build script cleanup Oct 10, 2018

@tmat tmat changed the title from WIP: Build script cleanup to Build script cleanup Oct 10, 2018

@tmat tmat merged commit 698d470 into dotnet:master Oct 10, 2018

7 of 8 checks passed

windows_release_vs-integration_prtest Build finished.
Details
Gen CI(dotnet-ci) - master/netci.groovy Build finished.
Details
WIP ready for review
Details
license/cla All CLA requirements met.
Details
microbuild_prtest Build finished.
Details
roslyn-CI #20181010.9 succeeded
Details
windows_debug_spanish_unit32_prtest Build finished.
Details
windows_debug_vs-integration_prtest Build finished.
Details

@tmat tmat deleted the tmat:ToolsetCleanup branch Oct 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment