Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change feature name to 'nullable reference types' #30585

Merged
merged 1 commit into from Oct 19, 2018
Merged

Change feature name to 'nullable reference types' #30585

merged 1 commit into from Oct 19, 2018

Conversation

cston
Copy link
Member

@cston cston commented Oct 18, 2018

Fixes #30555.

@cston cston requested a review from a team as a code owner October 18, 2018 16:08
@cston
Copy link
Member Author

cston commented Oct 18, 2018

@dotnet/roslyn-compiler please review.

jcouv
jcouv approved these changes Oct 18, 2018
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (iteration 1)

It will be slightly strange once we start tracking nullable value types too, but I don't have a much better idea...

@jcouv jcouv self-assigned this Oct 18, 2018
@jcouv jcouv added this to the 16.0 milestone Oct 18, 2018
gafter
gafter approved these changes Oct 18, 2018
View reviewed changes
Copy link
Member

@gafter gafter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jaredpar
Copy link
Member

approved to merge

AlekseyTs
AlekseyTs approved these changes Oct 18, 2018
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (iteration 1)

@cston
Copy link
Member Author

cston commented Oct 18, 2018

@dotnet-bot retest this please

@cston cston merged commit 2bf9edc into dotnet:dev16.0.x Oct 19, 2018
@cston cston deleted the 30555 branch October 19, 2018 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredpar jaredpar jaredpar approved these changes

@gafter gafter gafter approved these changes

@AlekseyTs AlekseyTs AlekseyTs approved these changes

@jcouv jcouv jcouv approved these changes

Assignees

@jcouv jcouv

Labels
Area-Compilers New Language Feature - Nullable Reference Types Nullable Reference Types
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cston @jaredpar @gafter @AlekseyTs @jcouv