New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Compilers filter for Roslyn #30880

Merged
merged 1 commit into from Nov 10, 2018

Conversation

Projects
None yet
2 participants
@agocke
Contributor

agocke commented Oct 31, 2018

Dev16 has a new feature that allows you to filter solutions down to a subset of the projects. I did this for the compiler layer and saved the result to this file.

@agocke agocke requested a review from jaredpar Oct 31, 2018

@jaredpar

This comment has been minimized.

Member

jaredpar commented Oct 31, 2018

What is this? Probably need to add a description to the PR.

@jaredpar

This comment has been minimized.

Member

jaredpar commented Nov 10, 2018

How do we use this file though? Basically if we merge what do I need to do in order to use this?

@agocke

This comment has been minimized.

Contributor

agocke commented Nov 10, 2018

Just double click on it with Dev16 P1 installed. Just like a sln file.

@jaredpar

This comment has been minimized.

Member

jaredpar commented Nov 10, 2018

This looks to just be Roslyn.sln slimmed down to Compilers.sln? Why would I use this over Compilers.sln?

I don't really object to this change. I'm just trying to understand what benifit it gives.

@agocke

This comment has been minimized.

Contributor

agocke commented Nov 10, 2018

Ah, two things really.

  1. We can dogfood the filters functionality, providing benefit to the broader team.
  2. In theory filters would allow us to more easily change the compilers and Roslyn solutions simultaneously, preventing them from going out of sync.
@jaredpar

This comment has been minimized.

Member

jaredpar commented Nov 10, 2018

We can dogfood the filters functionality, providing benefit to the broader team.

Always a winner.

In theory filters would allow us to more easily change the compilers and Roslyn solutions simultaneously, preventing them from going out of sync.

Don't think it does this. Unless I'm missing something this just changes the Visual Studio view, this isn't an item that we can target with msbuild. That would be necessary as we use Compilers.sln to filter the solution to projects that can be built with dotnet build. Or can msbuild target this too?

@agocke

This comment has been minimized.

Contributor

agocke commented Nov 10, 2018

On the dotnet build part -- no idea. Not even sure who to ask, tbh.

@agocke agocke merged commit 526cdfb into dotnet:master Nov 10, 2018

4 checks passed

license/cla All CLA requirements met.
Details
roslyn-CI #20181031.34 succeeded
Details
windows_debug_vs-integration_prtest Build finished.
Details
windows_release_vs-integration_prtest Build finished.
Details

@agocke agocke deleted the agocke:add-compilers-sln-filter branch Nov 10, 2018

wachulski added a commit to wachulski/roslyn that referenced this pull request Nov 12, 2018

Merge remote-tracking branch 'origin/master' into fix/27866/else-with…
…out-if-error-message

* origin/master: (174 commits)
  Add Compilers filter for Roslyn (dotnet#30880)
  Remove NonNullTypes context and other unnecessary information stored in TypeSymbolWithAnnotations. (dotnet#30913)
  Update BoundCall method based on receiver nullability (dotnet#31000)
  Make nullabiulity inference associative and commutative (dotnet#30990)
  Async-streams: minimal test for IOperation and CFG. Improve diagnostics (dotnet#30363)
  Add src.
  Add test.
  Remove dead code
  Update the build status table
  Script for generating our build status tables
  Add parsing tests to compiler benchmarks (dotnet#31033)
  Fix Edit and Continue in CPS projects
  Add comment
  Sorting.
  Save work
  Address PR feedback
  only produce optprof data on an official build
  Add bunch of exclusions to dead code analysis for special methods
  Disable WinRT tests on Linux (dotnet#31026)
  Change prerelease version to beta2 (dotnet#31017)
  ...

# Conflicts:
#	src/Compilers/CSharp/Portable/CSharpResources.resx
#	src/Compilers/CSharp/Portable/Errors/ErrorCode.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment