Make nullability inference associative and commutative #30990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dotnet#30966 Implements the spec change described in dotnet#30670 See also dotnet#30989
gafter
added
Area-Compilers
New Language Feature - Nullable Reference Types
jcouv
changed the title
|
@cston Could you please review this? |
cston
reviewed
Nov 7, 2018
| Diagnostic(ErrorCode.WRN_NoBestNullabilityConditionalExpression, "b ? ref y2 : ref x2").WithArguments("I<string>", "I<string?>").WithLocation(16, 10), | ||
| // (16,27): warning CS8619: Nullability of reference types in value of type 'I<string?>' doesn't match target type 'I<string>'. | ||
| // (b ? ref y2 : ref x2)/*T:I<string!>!*/.P.ToString(); | ||
| Diagnostic(ErrorCode.WRN_NullabilityMismatchInAssignment, "x2").WithArguments("I<string?>", "I<string>").WithLocation(16, 27), |
There was a problem hiding this comment.
WRN_NullabilityMismatchInAssignment [](start = 37, length = 35)
Should we avoid calling ApplyConversion in NullableWalker.VisitConditionalOperator if we reported WRN_NoBestNullability? (See similar handling in VisitArrayInitializer.)
There was a problem hiding this comment.
That would be a good way of reducing cascaded diagnostics in a future PR; see #30989
cston
reviewed
Nov 7, 2018
| Diagnostic(ErrorCode.WRN_CantInferNullabilityOfMethodTypeArgs, "F(x1, y1)").WithArguments("C.F<T>(T, T)").WithLocation(12, 9), | ||
| // (12,15): warning CS8620: Nullability of reference types in argument of type 'I<string?>' doesn't match target type 'I<string>' for parameter 'y' in 'I<string> C.F<I<string>>(I<string> x, I<string> y)'. | ||
| // F(x1, y1)/*T:I<string!>!*/; // 1 | ||
| Diagnostic(ErrorCode.WRN_NullabilityMismatchInArgument, "y1").WithArguments("I<string?>", "I<string>", "y", "I<string> C.F<I<string>>(I<string> x, I<string> y)").WithLocation(12, 15), |
There was a problem hiding this comment.
WRN_NullabilityMismatchInArgument [](start = 37, length = 33)
Should we avoid using the inferred type arguments in NullableWalker.InferMethodTypeArguments if there was a nullability mismatch from MethodTypeInferrer.Infer?
There was a problem hiding this comment.
That would be a good way of reducing cascaded diagnostics in a future PR; see #30989
cston
approved these changes
Nov 7, 2018
|
Approved for preview2 |
wachulski
added a commit
to wachulski/roslyn
that referenced
this pull request
Nov 12, 2018
…out-if-error-message * origin/master: (174 commits) Add Compilers filter for Roslyn (dotnet#30880) Remove NonNullTypes context and other unnecessary information stored in TypeSymbolWithAnnotations. (dotnet#30913) Update BoundCall method based on receiver nullability (dotnet#31000) Make nullabiulity inference associative and commutative (dotnet#30990) Async-streams: minimal test for IOperation and CFG. Improve diagnostics (dotnet#30363) Add src. Add test. Remove dead code Update the build status table Script for generating our build status tables Add parsing tests to compiler benchmarks (dotnet#31033) Fix Edit and Continue in CPS projects Add comment Sorting. Save work Address PR feedback only produce optprof data on an official build Add bunch of exclusions to dead code analysis for special methods Disable WinRT tests on Linux (dotnet#31026) Change prerelease version to beta2 (dotnet#31017) ... # Conflicts: # src/Compilers/CSharp/Portable/CSharpResources.resx # src/Compilers/CSharp/Portable/Errors/ErrorCode.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30966
Implements the spec change described in #30670
See also #30989