New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge dev16.0-preview2 to master #31041

Merged
merged 19 commits into from Nov 8, 2018

Conversation

Projects
None yet
6 participants
@dotnet-bot
Collaborator

dotnet-bot commented Nov 8, 2018

This is an automatically generated pull request from dev16.0-preview2 into master.

git fetch --all
git checkout merges/dev16.0-preview2-to-master
git reset --hard upstream/master
git merge upstream/dev16.0-preview2
# Fix merge conflicts
git commit
git push merges/dev16.0-preview2-to-master --force

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request.

mavasani and others added some commits Nov 6, 2018

Workaround in RemoveUnusedMembersDiagnosticAnalyzer for VB handles cl…
…ause

Fixes #30895

This analyzer does not function correctly in presence of VB handles clause due to IOperation bugs #30978 and #30979. This change adds a temporary workaround to the analyzer to handle this case specially.

TODO: File a bug to track reverting the temporary workaround once #30978 and #30979 are fixed.
Merge pull request #30982 from mavasani/Issue30965
Handle event symbols with explicit interface implementation in unused…
Merge pull request #30997 from genlu/fixSignatureHelper
Fix IndexOutOfRange exception in InvocationExpressionSignatureHelpProvider
Merge pull request #30980 from mavasani/WithEventsFix
Workaround in RemoveUnusedMembersDiagnosticAnalyzer for VB handles cl…
Merge pull request #31024 from sharwell/prefer-braces-style
Add csharp_prefer_braces to .editorconfig
Merge pull request #30984 from mavasani/Issue30894
Unused members analyzer: Do not flag write-only properties that are n…

@dotnet-bot dotnet-bot requested review from dotnet/roslyn-ide as code owners Nov 8, 2018

@dotnet-automerge-bot

Auto-approval

@dotnet-automerge-bot dotnet-automerge-bot merged commit e20ee16 into master Nov 8, 2018

4 checks passed

license/cla All CLA requirements met.
Details
roslyn-CI #20181107.46 succeeded
Details
windows_debug_vs-integration_prtest Build finished.
Details
windows_release_vs-integration_prtest Build finished.
Details

@dotnet-automerge-bot dotnet-automerge-bot deleted the merges/dev16.0-preview2-to-master branch Nov 8, 2018

@dotnet-bot dotnet-bot restored the merges/dev16.0-preview2-to-master branch Nov 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment