Merge master to dev16.1-preview1 #32218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract test from AbstractRemoveUnusedMembersDiagnosticAnalyzer for use in AbstractRemoveUnusedParametersAndValuesDiagnosticAnalyzer via a new SerializationConstructorCheck utility struct. Fixes #32133
This API is meant as a file system abstraction that can be mocked / replaced during testing. Reduced the API to the necessary member and moved strong name logic to the appropriate type.
Reduced it to the set of methods which reflect the API set. All of the actual implementation details were moved down to `DesktopStrongNameProvider`.
The intent is to merge the providers hence having them expose a capability doesn't make any sense. The code now just infers the mode based on the arguments and always uses the `DesktopStrongNameProvider`
Big chunk of usage removed with this change. Lots to go though.
Followed up on my questions around the use of `CryptoPublicKey` in `SourceAssemblySymbol` (both languages). Turns out this does appear to have a bug in how assembly attributes are processed. Filed #31985 to follow up on this.
The design of reference assemblies, no matter whether they are generated using `/ref` or `/refout` is that they are signed if strong signing would be done for an implementation assembly. This was implemented correctly for builder based signing but not for COM based. This PR fixes the signing to be consistent.
Removes the remaining TODO entries in `StrongNameProvider` and cleans up the structure of the type.
…lization-ctors IDE0060 doesn't warn about unused params in ISerializable constructors
Unify StrongNameProvider implementations
Filter out wpftemp projects.
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from master into dev16.1-preview1.
git fetch --all git checkout merges/master-to-dev16.1-preview1 git reset --hard upstream/dev16.1-preview1 git merge upstream/master # Fix merge conflicts git commit git push merges/master-to-dev16.1-preview1 --forceOnce all conflicts are resolved and all the tests pass, you are free to merge the pull request.