New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy nullability of struct fields of unconstrained type #32402

Merged
merged 1 commit into from Jan 12, 2019

Conversation

@cston
Copy link
Member

cston commented Jan 11, 2019

Fixes #32338.

@cston

This comment has been minimized.

Copy link
Member

cston commented Jan 11, 2019

@dotnet/roslyn-compiler please review.

@jcouv

jcouv approved these changes Jan 11, 2019

Copy link
Member

jcouv left a comment

LGTM Thanks (iteration 1)

@jcouv jcouv self-assigned this Jan 11, 2019

@cston

This comment has been minimized.

Copy link
Member

cston commented Jan 12, 2019

@dotnet/roslyn-compiler for a second review of this small change, thanks.

}
}";
var comp = CreateCompilation(source, options: WithNonNullTypesTrue());
// https://github.com/dotnet/roslyn/issues/29970: Should not report warning for `z.Item1`.

This comment has been minimized.

@AlekseyTs

AlekseyTs Jan 12, 2019

Contributor

#29970 [](start = 15, length = 45)

Consider adding this as another WorkItem #Pending

This comment has been minimized.

@cston

cston Jan 12, 2019

Member

Will add in next PR.


In reply to: 247292493 [](ancestors = 247292493)

@AlekseyTs
Copy link
Contributor

AlekseyTs left a comment

LGTM (iteration 1)

@cston cston merged commit e05f228 into dotnet:master Jan 12, 2019

2 of 3 checks passed

roslyn-integration-CI #20190111.25 failed
Details
license/cla All CLA requirements met.
Details
roslyn-CI #20190111.27 succeeded
Details

@cston cston deleted the cston:32338 branch Jan 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment