New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Arcade VS IBC training infrastructure #33133

Merged
merged 3 commits into from Feb 7, 2019

Conversation

Projects
None yet
3 participants
@tmat
Copy link
Member

tmat commented Feb 5, 2019

Removes VS IBC training operations from Roslyn build scripts and uses implementation provided by Arcade SDK.

Updates to the latest Arcade.

@tmat tmat force-pushed the ArcadeOptProf branch from 4e71cec to f6d64d4 Feb 5, 2019

@tmat tmat changed the title WIP: Use Arcade VS IBC training infrastructure Use Arcade VS IBC training infrastructure Feb 5, 2019

@@ -26,22 +26,16 @@ jobs:
steps:
- task: NuGetToolInstaller@0
inputs:
versionSpec: '4.9.2'

- task: NuGetCommand@2

This comment has been minimized.

@tmat

tmat Feb 5, 2019

Author Member

This is no longer necessary. We restore packages to repo-local .packages directory in official build. See https://github.com/dotnet/roslyn/pull/33133/files#diff-891b50b7d5fe7380fc246ed310019d61R138

tmat added some commits Feb 5, 2019

@tmat

This comment has been minimized.

Copy link
Member Author

tmat commented Feb 5, 2019

-vsDropName $(VisualStudio.DropName)
-vsDropAccessToken $(System.AccessToken)
/p:RepositoryName=$(Build.Repository.Name)
/p:VisualStudioIbcSourceBranchName="master-vs-deps"

This comment has been minimized.

@jaredpar

jaredpar Feb 6, 2019

Member

Why are we hard coding this branch name here instead of $(Build.SourceBranchName)?

This comment has been minimized.

@tmat

tmat Feb 6, 2019

Author Member

Because we only train IBC data from master-vs-deps, so other branches need to use master-vs-deps.

This comment has been minimized.

@jaredpar

jaredpar Feb 6, 2019

Member

Is that for the long term? That's going to fall over pretty soon here. By Friday master-vs-deps will be dev16.1. Won't that bust all of the training data we're inserting into dev16.0?

This comment has been minimized.

@tmat

tmat Feb 6, 2019

Author Member

We can change this any time we need.

This comment has been minimized.

@tmat

tmat Feb 6, 2019

Author Member

This is just a string. It can be whatever we want it to be. It just needs to match to the value that the Release Pipeline that produces the data uses.

This comment has been minimized.

@jaredpar

jaredpar Feb 6, 2019

Member

How do we control the string which is sent to the release pipeline?

This comment has been minimized.

@tmat

tmat Feb 6, 2019

Author Member

That's a parameter in the Release Pipeline definition:

image

This comment has been minimized.

@jaredpar

jaredpar Feb 6, 2019

Member

I must be missing something here. That uses $(SourceBranchName) which confuses me why we don't use it here.

This comment has been minimized.

@tmat

tmat Feb 7, 2019

Author Member

The Release Pipeline is independent from Signed builds. Each signed build ingests some optimization data but only some signed builds kick off IBC release pipeline (those building master-vs-deps currently)

Consider a feature branch that someone wants to build signed build from. If we used SourceBranchName here it would fail because IBC release pipeline is not running for that feature branch.

This comment has been minimized.

@tmat

tmat Feb 7, 2019

Author Member

An alternative approach would be to use $(SourceBranchName) here but set SkipApplyOptimizationData to false only for select branches.

/p:DotNetSignType=$(SignType)
/p:DotNetPublishToBlobFeed=true
/p:DotNetPublishBlobFeedKey=$(dotnetfeed-storage-access-key-1)
/p:DotNetPublishBlobFeedUrl=https://dotnetfeed.blob.core.windows.net/dotnet-core/index.json
/p:PublishToSymbolServer=true
/p:DotNetSymbolServerTokenMsdl=$(microsoft-symbol-server-pat)
/p:DotNetSymbolServerTokenSymWeb=$(symweb-symbol-server-pat)
/p:IbcOptimizationDataDir=$(Build.SourcesDirectory)\.o\\
/p:VisualStudioIbcDropId=75e3797e1105a4da4c10dddda76c3b9398f7725a/223453/935479/1

This comment has been minimized.

@jaredpar

jaredpar Feb 6, 2019

Member

What does this represent? It's the distributed build version of a magic number 😄

This comment has been minimized.

@tmat

tmat Feb 6, 2019

Author Member

This represents a fixed IBC data drop. Just a workaround for now. Once we get the infrastructure going again we will remove this line and the build will pick up the latest.

@tmat tmat merged commit 68b54ee into master Feb 7, 2019

1 check passed

license/cla All CLA requirements met.
Details

@tmat tmat deleted the ArcadeOptProf branch Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment