New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap parallel file parsing in fatal exception handler #33297

Merged
merged 1 commit into from Feb 11, 2019

Conversation

Projects
None yet
3 participants
@agocke
Copy link
Contributor

agocke commented Feb 11, 2019

Parallel.For operations wrap exceptions in an AggregateException, which
destroys dump information. This change should crash the process on a parse
exception and preserve the dump information for Watson.

Wrap parallel file parsing in fatal exception handler
Parallel.For operations wrap exceptions in an AggregateException, which
destroys dump information. This change should crash the process on a parse
exception and preserve the dump information for Watson.

@agocke agocke requested a review from dotnet/roslyn-compiler as a code owner Feb 11, 2019

@gafter

gafter approved these changes Feb 11, 2019

Copy link
Member

gafter left a comment

:shipit:

@agocke agocke merged commit 83fc2b5 into dotnet:master Feb 11, 2019

1 check passed

license/cla All CLA requirements met.
Details

@agocke agocke deleted the agocke:wrap-parse-file-in-fatal-handler branch Feb 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment