Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable async completion #33795

Merged
merged 11 commits into from Mar 3, 2019

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Mar 1, 2019

@sharwell sharwell added Area-Infrastructure Integration-Test Test failures in roslyn-integration-CI labels Mar 1, 2019
@sharwell sharwell force-pushed the enable-async-completion branch 5 times, most recently from 5b1add8 to e55e15c Compare Mar 2, 2019
@sharwell sharwell force-pushed the enable-async-completion branch from e55e15c to e2b11da Compare Mar 2, 2019
@sharwell sharwell marked this pull request as ready for review Mar 2, 2019
@sharwell sharwell requested a review from a team as a code owner Mar 2, 2019
@sharwell sharwell added this to the 16.0 milestone Mar 2, 2019
Copy link
Member

@jaredpar jaredpar left a comment

:shipit:

@sharwell sharwell merged commit 2cab0d7 into dotnet:dev16.0-vs-deps Mar 3, 2019
1 check passed
@sharwell sharwell deleted the enable-async-completion branch Mar 3, 2019
@@ -99,7 +101,7 @@ public void CtrlAltSpace()
VisualStudio.Editor.Verify.CurrentLineText("System.Console.WriteLine();$$", assertCaretPosition: true);
VisualStudio.Editor.SendKeys(VirtualKey.Home, Shift(VirtualKey.End), VirtualKey.Delete);

VisualStudio.ExecuteCommand(WellKnownCommandNames.Edit_ToggleCompletionMode);
VisualStudio.Editor.SendKeys(new KeyPress(VirtualKey.Space, ShiftState.Ctrl | ShiftState.Alt));
Copy link
Member

@jasonmalinowski jasonmalinowski Mar 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change is fine but just checking here -- did we break the command?

Copy link
Member Author

@sharwell sharwell Mar 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the command works, and we use the command in other test contexts. This was supposed to be a test for Ctrl+Alt+Space though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure Integration-Test Test failures in roslyn-integration-CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants