Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mitigation for GetTypeInfo on suppressed expression #34102

Merged
merged 2 commits into from Mar 14, 2019

Conversation

@jcouv
Copy link
Member

jcouv commented Mar 14, 2019

Completion in the IDE doesn't work because GetTypeInfo returns nothing for suppressed expressions. This PR mitigates this and provides the result from binding (while the deeper public API work is making progress).

FYI @ivanbasov @CyrusNajmabadi

@jcouv jcouv added this to the 16.1.P1 milestone Mar 14, 2019

@jcouv jcouv self-assigned this Mar 14, 2019

@jcouv jcouv requested a review from dotnet/roslyn-compiler as a code owner Mar 14, 2019

@cston

cston approved these changes Mar 14, 2019

@jcouv jcouv closed this Mar 14, 2019

@jcouv jcouv reopened this Mar 14, 2019

@jcouv

This comment has been minimized.

Copy link
Member Author

jcouv commented Mar 14, 2019

@dotnet/roslyn-compiler for second review. Thanks

// Need to verify the semantic model
// Tracked by https://github.com/dotnet/roslyn/issues/32661

var s = model.GetTypeInfo(suppressions[0]);

This comment has been minimized.

@AlekseyTs

AlekseyTs Mar 14, 2019

Contributor

GetTypeInfo [](start = 26, length = 11)

Consider also covering GetSymbolInfo.

@AlekseyTs
Copy link
Contributor

AlekseyTs left a comment

LGTM (iteration 1)

@jcouv jcouv merged commit d012716 into dotnet:master Mar 14, 2019

1 check passed

license/cla All CLA requirements met.
Details

@jcouv jcouv deleted the jcouv:type-info branch Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.