Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix struct layout error when nullable enabled: #34128

Merged
merged 2 commits into from Mar 15, 2019

Conversation

@chsienki
Copy link
Contributor

chsienki commented Mar 14, 2019

  • Change type comparison to ignore nullable
  • Add a test
  • Fix an existing test

Fixes #32934

Fix struct layout error when nullable enabled:
- Change type comparison to ignore nullable
- Add a test
- Fix an existing test

@chsienki chsienki added this to the 16.1.P1 milestone Mar 14, 2019

@chsienki chsienki marked this pull request as ready for review Mar 14, 2019

@chsienki chsienki requested a review from dotnet/roslyn-compiler as a code owner Mar 14, 2019

@chsienki

This comment has been minimized.

Copy link
Contributor Author

chsienki commented Mar 14, 2019

@dotnet/roslyn-compiler for review please

{
var source =
@"
#pragma warning disable 0169 // suppress field never used warning

This comment has been minimized.

@jcouv

jcouv Mar 14, 2019

Member

nit: you could also eliminate the warning by making the field public #Resolved

@jcouv

jcouv approved these changes Mar 14, 2019

Copy link
Member

jcouv left a comment

LGTM Thanks (iteration 1)

@jcouv jcouv self-assigned this Mar 15, 2019

@chsienki chsienki merged commit 087195e into dotnet:master Mar 15, 2019

1 check passed

license/cla All CLA requirements met.
Details

333fred added a commit to 333fred/roslyn that referenced this pull request Mar 19, 2019

Merge remote-tracking branch 'dotnet/master' into merge-master
* dotnet/master: (345 commits)
  Update indexers based on analyzer receiver (dotnet#34134)
  Skip test DecimalBinaryOp_03 (dotnet#34199)
  Remove earlier nullable documentation (dotnet#34153)
  Rewrite FindReferencesTests as theories
  Apply a hang mitigating timeout to ExecuteCommand
  Warn on __refvalue null dereference: (dotnet#34135)
  Update dependencies from https://github.com/dotnet/arcade build 20190312.7 (dotnet#34112)
  Update vs branch for 16.1
  Fix struct layout error when nullable enabled: (dotnet#34128)
  Remove IgnoreInsignificantNullableModifiersDifference (dotnet#34096)
  Add the correct nullable annotations to generated iterator code (dotnet#33986)
  Move Rename implementation to new fully loaded document API.
  handle encapsulate field command
  change the way extract method handle partial load
  handle orangize document
  Add back Go to definition method.
  Revert "Move Go to definition to new fully loaded document API."
  Revert "Move Find references implementation to new fully loaded document API."
  Move Find references implementation to new fully loaded document API.
  Track nullable state across boxing conversions (dotnet#34087)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.