Make struct types readonly in Microsoft.CodeAnalysis.Features #34478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredpar
reviewed
Mar 26, 2019
Member
jaredpar
left a comment
jaredpar
left a comment
There was a problem hiding this comment.
My review here was readonly, no comments were written.
jasonmalinowski
approved these changes
Mar 27, 2019
Member
jasonmalinowski
left a comment
jasonmalinowski
left a comment
There was a problem hiding this comment.
@jaredpar I assume there's no crazy way that adding 'readonly' is an API breaking change?
Contributor
Author
|
@jasonmalinowski removing it would be, but adding shouldn't cause problems |
Member
|
@sharwell: I'm just always paranoid because I've had the compiler team tell me things are safe, only to then be broken by them. 😄 |
Member
|
In short this change is fine and should be merged. More generally though the rule of thumb is the following:
|
sharwell
force-pushed
the
readonly-structs
branch
from
26a7b45 to
2f96377
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.