Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mac CI #34849

Merged
merged 10 commits into from Apr 12, 2019

Conversation

Projects
None yet
2 participants
@RikkiGibson
Copy link
Contributor

RikkiGibson commented Apr 8, 2019

No description provided.

RikkiGibson added some commits Apr 8, 2019

@RikkiGibson RikkiGibson closed this Apr 9, 2019

@RikkiGibson RikkiGibson reopened this Apr 9, 2019

@RikkiGibson RikkiGibson reopened this Apr 11, 2019

@RikkiGibson RikkiGibson marked this pull request as ready for review Apr 11, 2019

@RikkiGibson RikkiGibson requested a review from dotnet/roslyn-compiler as a code owner Apr 11, 2019

@RikkiGibson

This comment has been minimized.

Copy link
Contributor Author

RikkiGibson commented Apr 11, 2019

Draft PRs aren't kicking CI at the moment, so I'm using the "For Personal Review Only" tag instead.

Show resolved Hide resolved azure-pipelines.yml Outdated
Show resolved Hide resolved azure-pipelines.yml Outdated
public void DeeplyNestedGeneric()
{
int nestingLevel = (ExecutionConditionUtil.Architecture, ExecutionConditionUtil.Configuration) switch
{
_ when ExecutionConditionUtil.IsMacOS => 100,

This comment has been minimized.

Copy link
@RikkiGibson

RikkiGibson Apr 12, 2019

Author Contributor

This number seems pretty low even for debug. But I did find that 170 was too high.

public class WindowsOrLinuxOnly : ExecutionCondition
{
public override bool ShouldSkip => ExecutionConditionUtil.IsMacOS;
public override string SkipReason => "Test not supported on macOS";

This comment has been minimized.

Copy link
@jaredpar

jaredpar Apr 12, 2019

Member
Suggested change
public override string SkipReason => "Test not supported on macOS";
public override string SkipReason => "Test not supported on MacOS";
@RikkiGibson

This comment has been minimized.

Copy link
Contributor Author

RikkiGibson commented Apr 12, 2019

Odd, the mac run seems to have instantly blown up after pushing that config change. Maybe a transient issue?

@RikkiGibson RikkiGibson merged commit 66ac3f2 into dotnet:master Apr 12, 2019

1 check passed

license/cla All CLA requirements met.
Details

@RikkiGibson RikkiGibson deleted the RikkiGibson:mac-ci branch Apr 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.