Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to a newer version of CoreCLR #35542

Merged
merged 2 commits into from May 10, 2019

Conversation

Projects
None yet
6 participants
@AlekseyTs
Copy link
Contributor

commented May 6, 2019

Microsoft.NETCore.App 3.0.0-preview6-27706-07, SDK version 3.0.100-preview6-011773

Move to a newer version of CoreCLR
Microsoft.NETCore.App 3.0.0-preview6-27706-07, SDK version 3.0.100-preview6-011773

@AlekseyTs AlekseyTs marked this pull request as ready for review May 10, 2019

@AlekseyTs AlekseyTs requested review from dotnet/roslyn-compiler as code owners May 10, 2019

@AlekseyTs

This comment has been minimized.

Copy link
Contributor Author

commented May 10, 2019

@agocke

agocke approved these changes May 10, 2019

@AlekseyTs AlekseyTs merged commit 6d3463c into dotnet:master May 10, 2019

15 of 16 checks passed

roslyn-integration-CI Build #20190509.14 failed
Details
WIP Ready for review
Details
license/cla All CLA requirements met.
Details
roslyn-CI Build #20190509.15 succeeded
Details
roslyn-CI (Linux_Test coreclr) Linux_Test coreclr succeeded
Details
roslyn-CI (Linux_Test mono) Linux_Test mono succeeded
Details
roslyn-CI (MacOs_Test) MacOs_Test succeeded
Details
roslyn-CI (Windows_CoreClr_Unit_Tests debug) Windows_CoreClr_Unit_Tests debug succeeded
Details
roslyn-CI (Windows_CoreClr_Unit_Tests release) Windows_CoreClr_Unit_Tests release succeeded
Details
roslyn-CI (Windows_Correctness_Test) Windows_Correctness_Test succeeded
Details
roslyn-CI (Windows_Desktop_Spanish_Unit_Tests) Windows_Desktop_Spanish_Unit_Tests succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests debug_32) Windows_Desktop_Unit_Tests debug_32 succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests debug_64) Windows_Desktop_Unit_Tests debug_64 succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests release_32) Windows_Desktop_Unit_Tests release_32 succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests release_64) Windows_Desktop_Unit_Tests release_64 succeeded
Details
roslyn-CI (Windows_Determinism_Test) Windows_Determinism_Test succeeded
Details
@sharwell

This comment has been minimized.

Copy link
Member

commented May 12, 2019

@AlekseyTs @jaredpar @nguerrera Can we please stop updating this version until the following two items are resolved:

  1. Visual Studio has a sane error message for this case.
  2. It is possible to locate, download, and install the correct version. Either of the following would be acceptable:
    1. The download is the current preview version listed on dotnet.microsoft.com
    2. The build error when using the wrong version links to the correct version

The current error message is the following:

error MSB4044: The "GenerateDepsFile" task was not given a value for the required parameter "CompileReferences".

There are no easily-identifiable links or information to identify or get the correct version.

@jaredpar

This comment has been minimized.

Copy link
Member

commented May 13, 2019

@sharwell

Can we please stop updating this version until the following two items are resolved:

No. The compiler team depends on the runtime / SDK for testing features we're shipping in C# 8.0. It's important for us to update regularly here to ensure our features continue to work properly.

Visual Studio has a sane error message for this case.

I'm sympathetic to this case and wish VS was less silent here. But it's an orthogonal issue to us verifying that we're shipping a solid product. I encourage you to reach out ot the product team directly on this.

@jcouv

This comment has been minimized.

Copy link
Member

commented May 13, 2019

The current error message is [bad]

If there is a known pitfall in the short-term, can someone pro-actively message the team as a mitigation?
For the long-term, did we file an issue or communicate some asks to improve the situation?

@jaredpar

This comment has been minimized.

Copy link
Member

commented May 13, 2019

@jcouv

If there is a known pitfall in the short-term, can someone pro-actively message the team as a mitigation?
For the long-term, did we file an issue or communicate some asks to improve the situation?

The CLI / SDK team is aware of this problem. I'm not sure there are plans to fix it at the moment. But @KathleenDollard, @nguerrera can comment on it.

@sharwell

This comment has been minimized.

Copy link
Member

commented May 13, 2019

Also note that in the case of this upgrade, installing the new preview broke the build for branches that are still configured to use preview5.

@jaredpar

This comment has been minimized.

Copy link
Member

commented May 13, 2019

Also note that in the case of this upgrade, installing the new preview broke the build for branches that are still configured to use preview5.

Again seems like an excellent discussion to have with the SDK / CLI team. I've personally sent over my scenarios, and how the decisions they've made have increased the maintenance burden on repository owners. The behavior is still what it is and we can't block product evolution on this.

Have you emailed the product owners here or just commenting on our usage of the product?

@AlekseyTs

This comment has been minimized.

Copy link
Contributor Author

commented May 14, 2019

@sharwell Just an FYI, the https://github.com/dotnet/roslyn/blob/master/docs/contributing/Building%2C%20Debugging%2C%20and%20Testing%20on%20Windows.md document has the link to the SDK installer - https://dotnetcli.azureedge.net/dotnet/Sdk/3.0.100-preview6-011773/dotnet-sdk-3.0.100-preview6-011773-win-x64.exe. If you need a link for an installer for a different platform, you can find that from the console output of the corresponding CI job for a PR in Roslyn, the first thing CI job does, it downloads the SDK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.