Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the hosted pool for integration tests #35603

Merged
merged 9 commits into from May 15, 2019

Conversation

Projects
None yet
3 participants
@sharwell
Copy link
Member

commented May 9, 2019

No description provided.

@sharwell sharwell force-pushed the sharwell:hosted-pool branch 2 times, most recently from 5ab8efa to 9570caf May 12, 2019

@sharwell sharwell force-pushed the sharwell:hosted-pool branch 3 times, most recently from 06d74a6 to cee03f0 May 13, 2019

@sharwell sharwell force-pushed the sharwell:hosted-pool branch from cee03f0 to 854772f May 13, 2019

@sharwell sharwell force-pushed the sharwell:hosted-pool branch from 9e3e909 to 84a8294 May 14, 2019

@sharwell sharwell marked this pull request as ready for review May 14, 2019

@sharwell sharwell requested review from dotnet/roslyn-compiler as code owners May 14, 2019

@@ -149,6 +149,8 @@ public string WarningsNotAsErrors
get { return (string)_store[nameof(WarningsNotAsErrors)]; }
}

public string NullableContextOptions { get { return null; } set { } }

This comment has been minimized.

Copy link
@chsienki

chsienki May 15, 2019

Contributor

What is this needed for?

This comment has been minimized.

Copy link
@sharwell

sharwell May 15, 2019

Author Member

It shouldn't be needed with 854772f, but I got a failure in CI anyway. I'm planning to submit a follow-up PR to revert this change and it will merge as soon as we can get it to pass, which at the latest will be whenever the change that removed this property ships in a preview image.

When the failure occurs, csproj projects fail to load correctly in integration test runs.

This comment has been minimized.

Copy link
@sharwell

sharwell May 15, 2019

Author Member

➡️ Submitted #35725 to revert this change as a follow-up.

- task: PublishBuildArtifacts@1
displayName: Publish Secondary Logs
inputs:
PathtoPublish: '$(Build.SourcesDirectory)\artifacts\log2\$(_configuration)'

This comment has been minimized.

Copy link
@jaredpar

jaredpar May 15, 2019

Member

Don't think we should be craeting a log2 directory. That complicates our infrastructure here. Should be focusing on a single log dir.

This comment has been minimized.

Copy link
@sharwell

sharwell May 15, 2019

Author Member

This restored the ability to collect xunit.console.x86 logs following a hang. Test hangs cannot be diagnosed without this file.

I'm happy to remove this separation once we resolve the underlying issue, but I believe the inability to diagnose test failures is the more acute issue.

This comment has been minimized.

Copy link
@sharwell

sharwell May 15, 2019

Author Member

➡️ Submitted #35726 to revert this after the Azure Pipelines artifact investigation is completed.

This comment has been minimized.

Copy link
@jaredpar

jaredpar May 15, 2019

Member

What limitation in azure are you referring to? Our investigation with them revealed that it's almost certainly our problem, not there's.

This comment has been minimized.

Copy link
@sharwell

sharwell May 15, 2019

Author Member

Before this change, only 1 of 8 hung builds included the dump file (0/1 in 20190514.12, 0/3 in 20190509.23, and 1/4 in 20190509.7). After this change, both hung builds in 20190514.34 included this file and I was able to immediately correct the cause.

This comment has been minimized.

Copy link
@jaredpar

jaredpar May 15, 2019

Member

That just continues to confirm the problem is on our end, not Azure's. If this is an Azure bug then we need to have data to give them about it. Specifically, as they requested in the email, list the contents of the directory showing we wrote the file and they didn't upload it.

@sharwell sharwell merged commit 22286da into dotnet:master May 15, 2019

16 checks passed

WIP Ready for review
Details
license/cla All CLA requirements met.
Details
roslyn-CI Build #20190514.49 succeeded
Details
roslyn-CI (Linux_Test coreclr) Linux_Test coreclr succeeded
Details
roslyn-CI (Linux_Test mono) Linux_Test mono succeeded
Details
roslyn-CI (MacOs_Test) MacOs_Test succeeded
Details
roslyn-CI (Windows_CoreClr_Unit_Tests debug) Windows_CoreClr_Unit_Tests debug succeeded
Details
roslyn-CI (Windows_CoreClr_Unit_Tests release) Windows_CoreClr_Unit_Tests release succeeded
Details
roslyn-CI (Windows_Correctness_Test) Windows_Correctness_Test succeeded
Details
roslyn-CI (Windows_Desktop_Spanish_Unit_Tests) Windows_Desktop_Spanish_Unit_Tests succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests debug_32) Windows_Desktop_Unit_Tests debug_32 succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests debug_64) Windows_Desktop_Unit_Tests debug_64 succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests release_32) Windows_Desktop_Unit_Tests release_32 succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests release_64) Windows_Desktop_Unit_Tests release_64 succeeded
Details
roslyn-CI (Windows_Determinism_Test) Windows_Determinism_Test succeeded
Details
roslyn-integration-CI Build #20190514.47 succeeded
Details

@sharwell sharwell deleted the sharwell:hosted-pool branch May 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.