Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feeding VSSDK from new VSSDK channel #36000

Merged
merged 4 commits into from Jul 31, 2019

Conversation

@ivanbasov
Copy link
Contributor

commented May 28, 2019

No description provided.

@ivanbasov ivanbasov added the Area-IDE label May 28, 2019

@ivanbasov ivanbasov added this to the 16.2.P3 milestone May 28, 2019

@ivanbasov ivanbasov requested review from jasonmalinowski, dpoeschl and dotnet/roslyn-ide May 28, 2019

@@ -318,6 +318,7 @@
https://dotnetfeed.blob.core.windows.net/dotnet-core/index.json;
https://dotnet.myget.org/F/system-commandline/api/v3/index.json;
https://dotnetfeed.blob.core.windows.net/dotnet-coreclr/index.json;
https://pkgs.dev.azure.com/PublicArtifactsPreview/vside/_packaging/VSIDEPublicFeed@Local/nuget/v3/index.json

This comment has been minimized.

Copy link
@jasonmalinowski

jasonmalinowski May 28, 2019

Member

Can we remove a feed at the same time? I also see "preview" in this URL -- is it going to change at some point?

This comment has been minimized.

Copy link
@ivanbasov

ivanbasov May 28, 2019

Author Contributor

The Editor team suggested to use pkgs.dev.azure.com instead of vside.myget.org. They said it is easier for them to publish updates there regularly. This is the purpose of the PR. #Resolved

This comment has been minimized.

Copy link
@jasonmalinowski

jasonmalinowski May 28, 2019

Member

Can we remove vside.myget.org then?

This comment has been minimized.

Copy link
@JPWilli

JPWilli May 28, 2019

For total transparency, this feed is now in Azure DevOps beta testing, and WILL need to change at some point in the future. We're trying to use Roslyn as a proof that things are working well.

This comment has been minimized.

Copy link
@ivanbasov

ivanbasov May 28, 2019

Author Contributor

Can we remove vside.myget.org then?

Already :-) #Resolved

This comment has been minimized.

Copy link
@jasonmalinowski

jasonmalinowski May 28, 2019

Member

and WILL need to change at some point in the future

What's the timeline for that? And what does this mean for servicing? We can't be adding feeds that are going to disappear since then we won't be able to build our product. #Resolved

This comment has been minimized.

Copy link
@jasonmalinowski

jasonmalinowski May 28, 2019

Member

(and I'm sympathetic to that we may need to test things, let's just make sure we don't leave this dangling and screw up servicing.) #Resolved

@jinujoseph jinujoseph modified the milestones: 16.2.P3, 16.2 Jun 9, 2019

@ivanbasov ivanbasov force-pushed the ivanbasov:vssdk branch from 2e7a400 to aa0bb70 Jul 29, 2019

@ivanbasov

This comment has been minimized.

Copy link
Contributor Author

commented Jul 29, 2019

@jasonmalinowski , @heejaechang , @tmat please review
@jinujoseph please point to the right branch to merge #Resolved

@tmat

This comment has been minimized.

Copy link
Member

commented Jul 30, 2019

The same change is required in nuget.config as well.
https://github.com/dotnet/roslyn/blob/master/NuGet.config

Usage of the RestoreSources property is being deprecated and soon be removed. #Resolved

@jinujoseph jinujoseph modified the milestones: 16.2, 16.3 Jul 30, 2019

@genlu

This comment has been minimized.

Copy link
Member

commented Jul 30, 2019

Any reason why this change must be made in vs-deps? #Resolved

@genlu

genlu approved these changes Jul 30, 2019

@ivanbasov

This comment has been minimized.

Copy link
Contributor Author

commented Jul 30, 2019

Any reason why this change must be made in vs-deps?

I thought that infrastructure changes should be made in vs-deps. Then, when official packages will be published, we will update master. @jinujoseph and @jasonmalinowski to confirm #Resolved

@jasonmalinowski

This comment has been minimized.

Copy link
Member

commented Jul 30, 2019

Assuming the packages we all need in master are available in the feed, this should go into master. #Resolved

@ivanbasov

This comment has been minimized.

Copy link
Contributor Author

commented Jul 30, 2019

Let me change to master then. Thanks!


In reply to: 516574197 [](ancestors = 516574197)

@ivanbasov ivanbasov changed the base branch from master-vs-deps to master Jul 30, 2019

@ivanbasov ivanbasov force-pushed the ivanbasov:vssdk branch from 634acef to 22727c0 Jul 30, 2019

@ivanbasov ivanbasov modified the milestones: 16.3, 16.3.P3 Jul 30, 2019

@ivanbasov ivanbasov merged commit a172826 into dotnet:master Jul 31, 2019

20 checks passed

WIP Ready for review
Details
license/cla All CLA requirements met.
Details
roslyn-CI Build #20190730.38 succeeded
Details
roslyn-CI (Linux_Test coreclr) Linux_Test coreclr succeeded
Details
roslyn-CI (Linux_Test mono) Linux_Test mono succeeded
Details
roslyn-CI (MacOs_Test) MacOs_Test succeeded
Details
roslyn-CI (Windows_CoreClr_Unit_Tests debug) Windows_CoreClr_Unit_Tests debug succeeded
Details
roslyn-CI (Windows_CoreClr_Unit_Tests release) Windows_CoreClr_Unit_Tests release succeeded
Details
roslyn-CI (Windows_Correctness_Test) Windows_Correctness_Test succeeded
Details
roslyn-CI (Windows_Desktop_Spanish_Unit_Tests) Windows_Desktop_Spanish_Unit_Tests succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests debug_32) Windows_Desktop_Unit_Tests debug_32 succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests debug_64) Windows_Desktop_Unit_Tests debug_64 succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests release_32) Windows_Desktop_Unit_Tests release_32 succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests release_64) Windows_Desktop_Unit_Tests release_64 succeeded
Details
roslyn-CI (Windows_Determinism_Test) Windows_Determinism_Test succeeded
Details
roslyn-integration-CI Build #20190730.38 had test failures
Details
roslyn-integration-CI (VS_Integration debug_async) VS_Integration debug_async succeeded
Details
roslyn-integration-CI (VS_Integration debug_legacy) VS_Integration debug_legacy succeeded
Details
roslyn-integration-CI (VS_Integration release_async) VS_Integration release_async succeeded
Details
roslyn-integration-CI (VS_Integration release_legacy) VS_Integration release_legacy succeeded
Details

@ivanbasov ivanbasov deleted the ivanbasov:vssdk branch Jul 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.