Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax the rule that tries to get rid of this./me. in Roslyn code. #36886

Merged
merged 2 commits into from Jul 2, 2019

Conversation

Projects
None yet
3 participants
@CyrusNajmabadi
Copy link
Contributor

commented Jun 28, 2019

Fixes #36874

@CyrusNajmabadi

This comment has been minimized.

Copy link
Contributor Author

commented Jun 28, 2019

Tagging @mavasani @jasonmalinowski

There are roughly 1k instances of this just in the IDE alone.

Show resolved Hide resolved .editorconfig Outdated
@CyrusNajmabadi

This comment has been minimized.

Copy link
Contributor Author

commented Jul 2, 2019

@mavasani this all passed. can you merge?

@sharwell sharwell merged commit dca4d18 into dotnet:master Jul 2, 2019

16 checks passed

WIP Ready for review
Details
license/cla All CLA requirements met.
roslyn-CI Build #20190701.28 succeeded
Details
roslyn-CI (Linux_Test coreclr) Linux_Test coreclr succeeded
Details
roslyn-CI (Linux_Test mono) Linux_Test mono succeeded
Details
roslyn-CI (MacOs_Test) MacOs_Test succeeded
Details
roslyn-CI (Windows_CoreClr_Unit_Tests debug) Windows_CoreClr_Unit_Tests debug succeeded
Details
roslyn-CI (Windows_CoreClr_Unit_Tests release) Windows_CoreClr_Unit_Tests release succeeded
Details
roslyn-CI (Windows_Correctness_Test) Windows_Correctness_Test succeeded
Details
roslyn-CI (Windows_Desktop_Spanish_Unit_Tests) Windows_Desktop_Spanish_Unit_Tests succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests debug_32) Windows_Desktop_Unit_Tests debug_32 succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests debug_64) Windows_Desktop_Unit_Tests debug_64 succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests release_32) Windows_Desktop_Unit_Tests release_32 succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests release_64) Windows_Desktop_Unit_Tests release_64 succeeded
Details
roslyn-CI (Windows_Determinism_Test) Windows_Determinism_Test succeeded
Details
roslyn-integration-CI Build #20190701.29 succeeded
Details
@CyrusNajmabadi

This comment has been minimized.

Copy link
Contributor Author

commented Jul 2, 2019

Thanks!

@CyrusNajmabadi CyrusNajmabadi deleted the CyrusNajmabadi:thisNone branch Jul 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.