Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnC emit tests for C# 8.0 patterns #37025

Merged
merged 6 commits into from Jul 11, 2019

Conversation

@ivanbasov
Copy link
Contributor

commented Jul 5, 2019

No description provided.

@ivanbasov ivanbasov requested review from tmat, 333fred and gafter Jul 5, 2019

@ivanbasov ivanbasov requested a review from dotnet/roslyn-compiler as a code owner Jul 5, 2019

@ivanbasov ivanbasov requested a review from jcouv Jul 5, 2019

@gafter
Copy link
Member

left a comment

Please fix the problem exposed by the failing test.

@jcouv jcouv added this to the 16.3 milestone Jul 8, 2019

@gafter

gafter approved these changes Jul 11, 2019

Copy link
Member

left a comment

:shipit:

@gafter gafter merged commit d4a4944 into dotnet:master Jul 11, 2019

16 checks passed

WIP Ready for review
Details
license/cla All CLA requirements met.
Details
roslyn-CI Build #20190708.18 succeeded
Details
roslyn-CI (Linux_Test coreclr) Linux_Test coreclr succeeded
Details
roslyn-CI (Linux_Test mono) Linux_Test mono succeeded
Details
roslyn-CI (MacOs_Test) MacOs_Test succeeded
Details
roslyn-CI (Windows_CoreClr_Unit_Tests debug) Windows_CoreClr_Unit_Tests debug succeeded
Details
roslyn-CI (Windows_CoreClr_Unit_Tests release) Windows_CoreClr_Unit_Tests release succeeded
Details
roslyn-CI (Windows_Correctness_Test) Windows_Correctness_Test succeeded
Details
roslyn-CI (Windows_Desktop_Spanish_Unit_Tests) Windows_Desktop_Spanish_Unit_Tests succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests debug_32) Windows_Desktop_Unit_Tests debug_32 succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests debug_64) Windows_Desktop_Unit_Tests debug_64 succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests release_32) Windows_Desktop_Unit_Tests release_32 succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests release_64) Windows_Desktop_Unit_Tests release_64 succeeded
Details
roslyn-CI (Windows_Determinism_Test) Windows_Determinism_Test succeeded
Details
roslyn-integration-CI Build #20190708.18 succeeded
Details
@CyrusNajmabadi

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

@ivanbasov This appears to have broken builds completely. All my builds are failing with:

F:\workspace\_work\1\s\src\Compilers\CSharp\Test\Emit\Emit\EditAndContinue\EditAndContinueTests.cs(9856,85): error CS0117: 'ConditionalSkipReason' does not contain a definition for 'EditAndContinueRequiresDesktop' [F:\workspace\_work\1\s\src\Compilers\CSharp\Test\Emit\Microsoft.CodeAnalysis.CSharp.Emit.UnitTests.csproj]
F:\workspace\_work\1\s\src\Compilers\CSharp\Test\Emit\Emit\EditAndContinue\EditAndContinueTests.cs(9856,85): error CS0117: 'ConditionalSkipReason' does not contain a definition for 'EditAndContinueRequiresDesktop' [F:\workspace\_work\1\s\src\Compilers\CSharp\Test\Emit\Microsoft.CodeAnalysis.CSharp.Emit.UnitTests.csproj]
    0 Warning(s)
    2 Error(s)

Tagging @jasonmalinowski @dotnet/roslyn-infrastructure

See https://dev.azure.com/dnceng/public/_build/results?buildId=261072&view=logs for example.

@tmat

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

Likely bad merge. Fixing.

@tmat tmat referenced this pull request Jul 11, 2019

Closed

Make test unconditional #37164

333fred added a commit to 333fred/roslyn that referenced this pull request Jul 11, 2019

Merge remote-tracking branch 'dotnet/master' into rename-property
* dotnet/master:
  Fix master build (dotnet#37163)
  Add error for multiple null suppressions (dotnet#37139)
  Check for uninitialized non-nullable field-like events (dotnet#37073)
  EnC emit tests for C# 8.0 patterns (dotnet#37025)
  Update dependencies from https://github.com/dotnet/arcade build 20190710.8
  Update dependencies from https://github.com/dotnet/arcade build 20190709.6
  [master] Update dependencies from dotnet/arcade (dotnet#37001)
  Add annotations to HostWorkspaceServices.cs and HostLanguageServices.cs
  Add nullable annotations to members in Solution.cs, SolutionInfo.cs, and SolutionState.cs
  Annotate Contract.cs
  Add nullable annotations and fixes to Workspace.cs
  Fix typo in documentation comment for Workspace.Dispose
  Check in copy of NullableAttributes.cs copied from coreclr
  Use switch expressions to simplify GetAccessibilityAndModifiers

333fred added a commit to cston/roslyn that referenced this pull request Jul 12, 2019

Merge remote-tracking branch 'dotnet/master' into 36047
* dotnet/master: (38 commits)
  Fix master build (dotnet#37163)
  Add error for multiple null suppressions (dotnet#37139)
  Check for uninitialized non-nullable field-like events (dotnet#37073)
  EnC emit tests for C# 8.0 patterns (dotnet#37025)
  Update dependencies from https://github.com/dotnet/arcade build 20190710.8
  Update dependencies from https://github.com/dotnet/arcade build 20190709.6
  [master] Update dependencies from dotnet/arcade (dotnet#37001)
  Update to System.Memory 4.5.3 (dotnet#36956)
  Copy sources from Versions.props to NuGet.config (dotnet#37123)
  Add netstandard to the exclusion list for the AnalyzerConsistencyChecker (dotnet#36976)
  Fix crash in semantic model when using unmanaged constraint (dotnet#37022)
  Add annotations to HostWorkspaceServices.cs and HostLanguageServices.cs
  Add nullable annotations to members in Solution.cs, SolutionInfo.cs, and SolutionState.cs
  Annotate Contract.cs
  Add nullable annotations and fixes to Workspace.cs
  Remove reflection based workaround for IRecursivePatternOperation
  Fix tests
  Update Helpers.cs
  Fix typo in documentation comment for Workspace.Dispose
  Check in copy of NullableAttributes.cs copied from coreclr
  ...
@jasonmalinowski

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

@CyrusNajmabadi The build has been fixed up.

333fred added a commit to 333fred/roslyn that referenced this pull request Jul 12, 2019

Merge remote-tracking branch 'dotnet/master' into nullable-file-info
* dotnet/master: (135 commits)
  PR feedback cleenup.
  Handle synthesized top-level types in EnC symbol matcher (dotnet#36854)
  Add nullability parameters to Compilation.Create*Type() (dotnet#37048)
  Apply Maybe/NotNull when getting default value of fields and properties (dotnet#37135)
  Fix master build (dotnet#37163)
  Add comment for header extraction.
  Moved IsInLocalFunctionHeader to SyntaxFactsService.
  Cleanup.
  Move 'Wrapping' code actions down to 'Feature' layer.
  Add error for multiple null suppressions (dotnet#37139)
  Check for uninitialized non-nullable field-like events (dotnet#37073)
  Rename TypeArgumentsNullableAnnotations to TypeArgumentNullableAnnotations.
  Improved comment for namedArgRefactoring.
  Fix xml comment.
  PR feedback cleanup, simplified getting NumericLiteralToken, etc.
  EnC emit tests for C# 8.0 patterns (dotnet#37025)
  Enabled RefactoringHelpers to handle location in whitespace.
  Update dependencies from https://github.com/dotnet/arcade build 20190710.8
  Update dependencies from https://github.com/dotnet/arcade build 20190709.6
  [master] Update dependencies from dotnet/arcade (dotnet#37001)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.