Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy sources from Versions.props to NuGet.config #37123

Merged
merged 1 commit into from Jul 11, 2019

Conversation

Projects
None yet
2 participants
@jcagme
Copy link
Contributor

commented Jul 10, 2019

TL;DR

We need that all restore sources are located in NuGet.config since internal feeds can only be restored from there. More details including next steps here

@jcagme

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2019

@jaredpar PTAL

@tmat

tmat approved these changes Jul 11, 2019

@jcagme

This comment has been minimized.

Copy link
Contributor Author

commented Jul 11, 2019

@tmat can you merge please? I don't have permissions

@tmat tmat merged commit cf0a5b4 into dotnet:master Jul 11, 2019

20 checks passed

WIP Ready for review
Details
license/cla All CLA requirements met.
Details
roslyn-CI Build #20190710.50 succeeded
Details
roslyn-CI (Linux_Test coreclr) Linux_Test coreclr succeeded
Details
roslyn-CI (Linux_Test mono) Linux_Test mono succeeded
Details
roslyn-CI (MacOs_Test) MacOs_Test succeeded
Details
roslyn-CI (Windows_CoreClr_Unit_Tests debug) Windows_CoreClr_Unit_Tests debug succeeded
Details
roslyn-CI (Windows_CoreClr_Unit_Tests release) Windows_CoreClr_Unit_Tests release succeeded
Details
roslyn-CI (Windows_Correctness_Test) Windows_Correctness_Test succeeded
Details
roslyn-CI (Windows_Desktop_Spanish_Unit_Tests) Windows_Desktop_Spanish_Unit_Tests succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests debug_32) Windows_Desktop_Unit_Tests debug_32 succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests debug_64) Windows_Desktop_Unit_Tests debug_64 succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests release_32) Windows_Desktop_Unit_Tests release_32 succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests release_64) Windows_Desktop_Unit_Tests release_64 succeeded
Details
roslyn-CI (Windows_Determinism_Test) Windows_Determinism_Test succeeded
Details
roslyn-integration-CI Build #20190710.50 had test failures
Details
roslyn-integration-CI (VS_Integration debug_async) VS_Integration debug_async succeeded
Details
roslyn-integration-CI (VS_Integration debug_legacy) VS_Integration debug_legacy succeeded
Details
roslyn-integration-CI (VS_Integration release_async) VS_Integration release_async succeeded
Details
roslyn-integration-CI (VS_Integration release_legacy) VS_Integration release_legacy succeeded
Details

333fred added a commit to cston/roslyn that referenced this pull request Jul 12, 2019

Merge remote-tracking branch 'dotnet/master' into 36047
* dotnet/master: (38 commits)
  Fix master build (dotnet#37163)
  Add error for multiple null suppressions (dotnet#37139)
  Check for uninitialized non-nullable field-like events (dotnet#37073)
  EnC emit tests for C# 8.0 patterns (dotnet#37025)
  Update dependencies from https://github.com/dotnet/arcade build 20190710.8
  Update dependencies from https://github.com/dotnet/arcade build 20190709.6
  [master] Update dependencies from dotnet/arcade (dotnet#37001)
  Update to System.Memory 4.5.3 (dotnet#36956)
  Copy sources from Versions.props to NuGet.config (dotnet#37123)
  Add netstandard to the exclusion list for the AnalyzerConsistencyChecker (dotnet#36976)
  Fix crash in semantic model when using unmanaged constraint (dotnet#37022)
  Add annotations to HostWorkspaceServices.cs and HostLanguageServices.cs
  Add nullable annotations to members in Solution.cs, SolutionInfo.cs, and SolutionState.cs
  Annotate Contract.cs
  Add nullable annotations and fixes to Workspace.cs
  Remove reflection based workaround for IRecursivePatternOperation
  Fix tests
  Update Helpers.cs
  Fix typo in documentation comment for Workspace.Dispose
  Check in copy of NullableAttributes.cs copied from coreclr
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.