Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Build badges: #37412

Merged
merged 3 commits into from Aug 22, 2019

Conversation

@chsienki
Copy link
Contributor

commented Jul 22, 2019

  • Update generate script
  • Update readme.me with latest run of script
Fix Build badges:
 - Update generate script
 - Update readme.me with latest run of script
@chsienki

This comment has been minimized.

Copy link
Contributor Author

commented Jul 22, 2019

@dotnet/roslyn-infrastructure for review please

scripts/generate-badges.ps1 Outdated Show resolved Hide resolved
@@ -10,17 +10,22 @@ $branchNames = @(
function Get-AzureBadge($branchName, $jobName, $configName, [switch]$integration = $false) {
$name = if ($integration) { "roslyn-integration-CI" } else { "roslyn-CI" }
$id = if ($integration) { 245 } else { 15 }
$template = "[![Build Status](https://dev.azure.com/dnceng/public/_apis/build/status/dotnet/roslyn/$($name)?branchname=$branchName&jobname=$jobName&configuration=$configName)]"
$template = "[![Build Status](https://dev.azure.com/dnceng/public/_apis/build/status/dotnet/roslyn/$($name)?branchname=$branchName&jobname=$jobName&configuration=$jobName$configName)]"

This comment has been minimized.

Copy link
@sharwell

sharwell Jul 25, 2019

Member

💡 It would be nice to fix the labels again

Suggested change
$template = "[![Build Status](https://dev.azure.com/dnceng/public/_apis/build/status/dotnet/roslyn/$($name)?branchname=$branchName&jobname=$jobName&configuration=$jobName$configName)]"
$template = "[![Build Status](https://dev.azure.com/dnceng/public/_apis/build/status/dotnet/roslyn/$($name)?branchname=$branchName&jobname=$jobName&configuration=$jobName$configName&label=build)]"
chsienki and others added 2 commits Jul 29, 2019
Update scripts/generate-badges.ps1
Accept suggested column names

Co-Authored-By: Sam Harwell <sam@tunnelvisionlabs.com>
@chsienki

This comment has been minimized.

Copy link
Contributor Author

commented Aug 22, 2019

@chsienki chsienki merged commit 28fdbf2 into dotnet:master Aug 22, 2019

20 checks passed

WIP Ready for review
Details
license/cla All CLA requirements met.
Details
roslyn-CI Build #20190729.41 succeeded
Details
roslyn-CI (Linux_Test coreclr) Linux_Test coreclr succeeded
Details
roslyn-CI (Linux_Test mono) Linux_Test mono succeeded
Details
roslyn-CI (MacOs_Test) MacOs_Test succeeded
Details
roslyn-CI (Windows_CoreClr_Unit_Tests debug) Windows_CoreClr_Unit_Tests debug succeeded
Details
roslyn-CI (Windows_CoreClr_Unit_Tests release) Windows_CoreClr_Unit_Tests release succeeded
Details
roslyn-CI (Windows_Correctness_Test) Windows_Correctness_Test succeeded
Details
roslyn-CI (Windows_Desktop_Spanish_Unit_Tests) Windows_Desktop_Spanish_Unit_Tests succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests debug_32) Windows_Desktop_Unit_Tests debug_32 succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests debug_64) Windows_Desktop_Unit_Tests debug_64 succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests release_32) Windows_Desktop_Unit_Tests release_32 succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests release_64) Windows_Desktop_Unit_Tests release_64 succeeded
Details
roslyn-CI (Windows_Determinism_Test) Windows_Determinism_Test succeeded
Details
roslyn-integration-CI Build #20190729.41 succeeded
Details
roslyn-integration-CI (VS_Integration debug_async) VS_Integration debug_async succeeded
Details
roslyn-integration-CI (VS_Integration debug_legacy) VS_Integration debug_legacy succeeded
Details
roslyn-integration-CI (VS_Integration release_async) VS_Integration release_async succeeded
Details
roslyn-integration-CI (VS_Integration release_legacy) VS_Integration release_legacy succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.