Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to new ilasm version #37878

Merged
merged 9 commits into from Aug 12, 2019

Conversation

@jaredpar
Copy link
Member

commented Aug 9, 2019

The latest version of ilasm produced by coreclr is now a fully
independent executable; it no longer depends on having a full runtime
laid down next to it.

This means we can vastly simplify how it is deployde in our
infrastructure. The package can now be included and have ilasm manually
copied out. This is similar to the approach that we take for our
diasymreader native dependencies.

closes #37582
related #25930, #25144

Move to new ilasm version
The latest version of ilasm produced by coreclr is now a fully
independent executable; it no longer depends on having a full runtime
laid down next to it.

This means we can vastly simplify how it is deployde in our
infrastructure. The package can now be included and have ilasm manually
copied out. This is similar to the approach that we take for our
diasymreader native dependencies.

closes #37582
related #25930, #25144

@jaredpar jaredpar force-pushed the jaredpar:fix-il branch from 01cd532 to c04a037 Aug 9, 2019

jaredpar added some commits Aug 9, 2019

Fix casing errors
NuPkg files are unpacked using lower case path names on Linux. This is
why the build wasn't copying the files.
Include more projects
Including more projects that have a dependency on ilasm.

@jaredpar jaredpar marked this pull request as ready for review Aug 12, 2019

@jaredpar jaredpar requested review from dotnet/roslyn-compiler as code owners Aug 12, 2019

@jaredpar

This comment has been minimized.

Copy link
Member Author

commented Aug 12, 2019

jaredpar and others added some commits Aug 12, 2019

Update src/Test/Utilities/Portable/Metadata/IlasmUtilities.cs
Co-Authored-By: Nick Guerrera <nicholg@microsoft.com>
Use destkop ilasm
The desktop ilasm contains features not present in coreclr; specifically
the ability to generate PDB files for net modules. Need to continue
using desktop ilasm as long as our tests depend on this.

@jaredpar jaredpar force-pushed the jaredpar:fix-il branch from 012b881 to bc0d55c Aug 12, 2019

@AlekseyTs

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

<MicrosoftNetCoreILAsmVersion>3.0.0-preview6-27721-71</MicrosoftNetCoreILAsmVersion>

Do we still need this property and the one below?


Refers to: eng/Versions.props:76 in bc0d55c. [](commit_id = bc0d55c, deletion_comment = False)

@jaredpar

This comment has been minimized.

Copy link
Member Author

commented Aug 12, 2019

<MicrosoftNetCoreILAsmVersion>3.0.0-preview6-27721-71</MicrosoftNetCoreILAsmVersion>

Good catch. Don't think that is used anymore.


In reply to: 520556648 [](ancestors = 520556648)


Refers to: eng/Versions.props:76 in bc0d55c. [](commit_id = bc0d55c, deletion_comment = False)

@jaredpar jaredpar merged commit 52b72fa into dotnet:master Aug 12, 2019

20 checks passed

WIP Ready for review
Details
license/cla All CLA requirements met.
Details
roslyn-CI Build #20190812.34 succeeded
Details
roslyn-CI (Linux_Test coreclr) Linux_Test coreclr succeeded
Details
roslyn-CI (Linux_Test mono) Linux_Test mono succeeded
Details
roslyn-CI (MacOs_Test) MacOs_Test succeeded
Details
roslyn-CI (Windows_CoreClr_Unit_Tests debug) Windows_CoreClr_Unit_Tests debug succeeded
Details
roslyn-CI (Windows_CoreClr_Unit_Tests release) Windows_CoreClr_Unit_Tests release succeeded
Details
roslyn-CI (Windows_Correctness_Test) Windows_Correctness_Test succeeded
Details
roslyn-CI (Windows_Desktop_Spanish_Unit_Tests) Windows_Desktop_Spanish_Unit_Tests succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests debug_32) Windows_Desktop_Unit_Tests debug_32 succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests debug_64) Windows_Desktop_Unit_Tests debug_64 succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests release_32) Windows_Desktop_Unit_Tests release_32 succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests release_64) Windows_Desktop_Unit_Tests release_64 succeeded
Details
roslyn-CI (Windows_Determinism_Test) Windows_Determinism_Test succeeded
Details
roslyn-integration-CI Build #20190812.34 succeeded
Details
roslyn-integration-CI (VS_Integration debug_async) VS_Integration debug_async succeeded
Details
roslyn-integration-CI (VS_Integration debug_legacy) VS_Integration debug_legacy succeeded
Details
roslyn-integration-CI (VS_Integration release_async) VS_Integration release_async succeeded
Details
roslyn-integration-CI (VS_Integration release_legacy) VS_Integration release_legacy succeeded
Details

@jaredpar jaredpar deleted the jaredpar:fix-il branch Aug 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.