Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release/dev16.3-preview2 to master #37957

Merged

Conversation

@dotnet-bot
Copy link
Collaborator

commented Aug 13, 2019

This is an automatically generated pull request from release/dev16.3-preview2 into master.
(created from a manual run of the PR generation tool)

git fetch --all
git checkout merges/release/dev16.3-preview2-to-master
git reset --hard upstream/master
git merge upstream/release/dev16.3-preview2
# Fix merge conflicts
git commit
git push upstream merges/release/dev16.3-preview2-to-master --force

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request.

JoeRobich added some commits Aug 12, 2019

Merge pull request #37939 from JoeRobich/make-languageserver_client-p…
…rivate

Mark M.VS.LanguageServer.Client as a private package

@dotnet-bot dotnet-bot requested a review from dotnet/roslyn-infrastructure as a code owner Aug 13, 2019

@v-asdhin

This comment has been minimized.

Copy link

commented Aug 14, 2019

@agocke All roslyn-CI and roslyn-integration-CI checks failed. Please have a look.

@msftbot

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

Hello @agocke!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@JoeRobich JoeRobich closed this Aug 14, 2019

@JoeRobich JoeRobich reopened this Aug 14, 2019

@JoeRobich

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

The checks were linked to the wrong CI

@dotnet-automerge-bot
Copy link
Collaborator

left a comment

Auto-approval

@dotnet-automerge-bot dotnet-automerge-bot merged commit fbc6964 into master Aug 14, 2019

20 checks passed

WIP Ready for review
Details
license/cla All CLA requirements met.
roslyn-CI Build #20190814.15 succeeded
Details
roslyn-CI (Linux_Test coreclr) Linux_Test coreclr succeeded
Details
roslyn-CI (Linux_Test mono) Linux_Test mono succeeded
Details
roslyn-CI (MacOs_Test) MacOs_Test succeeded
Details
roslyn-CI (Windows_CoreClr_Unit_Tests debug) Windows_CoreClr_Unit_Tests debug succeeded
Details
roslyn-CI (Windows_CoreClr_Unit_Tests release) Windows_CoreClr_Unit_Tests release succeeded
Details
roslyn-CI (Windows_Correctness_Test) Windows_Correctness_Test succeeded
Details
roslyn-CI (Windows_Desktop_Spanish_Unit_Tests) Windows_Desktop_Spanish_Unit_Tests succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests debug_32) Windows_Desktop_Unit_Tests debug_32 succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests debug_64) Windows_Desktop_Unit_Tests debug_64 succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests release_32) Windows_Desktop_Unit_Tests release_32 succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests release_64) Windows_Desktop_Unit_Tests release_64 succeeded
Details
roslyn-CI (Windows_Determinism_Test) Windows_Determinism_Test succeeded
Details
roslyn-integration-CI Build #20190814.15 succeeded
Details
roslyn-integration-CI (VS_Integration debug_async) VS_Integration debug_async succeeded
Details
roslyn-integration-CI (VS_Integration debug_legacy) VS_Integration debug_legacy succeeded
Details
roslyn-integration-CI (VS_Integration release_async) VS_Integration release_async succeeded
Details
roslyn-integration-CI (VS_Integration release_legacy) VS_Integration release_legacy succeeded
Details

@dotnet-automerge-bot dotnet-automerge-bot deleted the merges/release/dev16.3-preview2-to-master branch Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.