Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Markdown formatting of Breaking changes documents #38273

Merged
merged 3 commits into from Sep 9, 2019

Conversation

@svick
Copy link
Contributor

commented Aug 24, 2019

Not sure if release/dev16.4-preview1 is the right target branch for a PR that doesn't change any code, but targeting that branch just in case anyway.

@JoeRobich JoeRobich closed this Aug 29, 2019

@JoeRobich

This comment has been minimized.

Copy link
Member

commented Aug 29, 2019

Sorry, I should have retargeted these PRs before removing that branch. Repushed branch and will reopen and retarget.

@JoeRobich JoeRobich reopened this Aug 29, 2019

@JoeRobich JoeRobich changed the base branch from release/dev16.4-preview1 to master Aug 29, 2019

@vatsalyaagrawal vatsalyaagrawal added this to InQueue in IDE: CommunityPR via automation Sep 4, 2019

@jinujoseph jinujoseph moved this from InQueue to BuddyAssigned in IDE: CommunityPR Sep 9, 2019

Update language tag
Co-Authored-By: Sam Harwell <sam@tunnelvisionlabs.com>

IDE: CommunityPR automation moved this from BuddyAssigned to LGTM Sep 9, 2019

@sharwell sharwell added Area-Compilers and removed Area-IDE labels Sep 9, 2019

@JoeRobich
Copy link
Member

left a comment

Thanks Petr!

@svick

This comment has been minimized.

Copy link
Contributor Author

commented Sep 9, 2019

@sharwell I have fixed the cases that you mentioned, and also few others in the same document.

@JoeRobich JoeRobich merged commit b4c6fe0 into dotnet:master Sep 9, 2019

20 checks passed

WIP Ready for review
Details
license/cla All CLA requirements met.
Details
roslyn-CI Build #20190909.10 succeeded
Details
roslyn-CI (Linux_Test coreclr) Linux_Test coreclr succeeded
Details
roslyn-CI (MacOs_Test) MacOs_Test succeeded
Details
roslyn-CI (SourceBuild_Test) SourceBuild_Test succeeded
Details
roslyn-CI (Windows_CoreClr_Unit_Tests debug) Windows_CoreClr_Unit_Tests debug succeeded
Details
roslyn-CI (Windows_CoreClr_Unit_Tests release) Windows_CoreClr_Unit_Tests release succeeded
Details
roslyn-CI (Windows_Correctness_Test) Windows_Correctness_Test succeeded
Details
roslyn-CI (Windows_Desktop_Spanish_Unit_Tests) Windows_Desktop_Spanish_Unit_Tests succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests debug_32) Windows_Desktop_Unit_Tests debug_32 succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests debug_64) Windows_Desktop_Unit_Tests debug_64 succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests release_32) Windows_Desktop_Unit_Tests release_32 succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests release_64) Windows_Desktop_Unit_Tests release_64 succeeded
Details
roslyn-CI (Windows_Determinism_Test) Windows_Determinism_Test succeeded
Details
roslyn-integration-CI Build #20190909.10 succeeded
Details
roslyn-integration-CI (VS_Integration debug_async) VS_Integration debug_async succeeded
Details
roslyn-integration-CI (VS_Integration debug_legacy) VS_Integration debug_legacy succeeded
Details
roslyn-integration-CI (VS_Integration release_async) VS_Integration release_async succeeded
Details
roslyn-integration-CI (VS_Integration release_legacy) VS_Integration release_legacy succeeded
Details

IDE: CommunityPR automation moved this from LGTM to Completed Sep 9, 2019

@svick svick deleted the svick:breaking-change-formatting branch Sep 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.