Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master to master-vs-deps #40945

Merged
merged 18 commits into from Jan 14, 2020
Merged

Conversation

@dotnet-bot
Copy link
Contributor

dotnet-bot commented Jan 14, 2020

This is an automatically generated pull request from master into master-vs-deps.

git fetch --all
git checkout merges/master-to-master-vs-deps
git reset --hard upstream/master-vs-deps
git merge upstream/master
# Fix merge conflicts
git commit
git push upstream merges/master-to-master-vs-deps --force

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request.

sharwell and others added 18 commits Jan 7, 2020
Mostly straightforward annotation. The SymbolComparer is deleted because
the code was unused.
…re missing (#40704)
Don't produce multiple redundant spans for crefs.
Add EnumCastDefinitelyCantBeRemoved edge case for casts to numeric types
Null annotate Quick Info
…ty if solution crawler is turned off with the option `InternalSolutionCrawlerOptions.SolutionCrawler`.

This is needed for our internal RPS performance tests which intend to turn off solution crawler for certain scenarios to reduce noise from it.
* Remove unused parameter and clean up MemoryMappedInfo
…eadonly-generic-conditional-access

Revert "Improve the code gen for a conditional access on a readonly unconstrained field"
This will cause local Visual Studio and VS Code test runners to run under
CoreCLR by default. This will only affect tests which are multi-targeted,
which today only includes the compiler unit tests.
Ensure that we don't kick off SolutionCrawler's Reanalyze functionali…
@dotnet-bot dotnet-bot requested review from dotnet/roslyn-compiler as code owners Jan 14, 2020
@msftbot
msftbot bot approved these changes Jan 14, 2020
Copy link
Contributor

msftbot bot left a comment

Auto-approval

@msftbot msftbot bot merged commit 089058b into master-vs-deps Jan 14, 2020
18 checks passed
18 checks passed
WIP Ready for review
Details
license/cla All CLA requirements met.
Details
roslyn-CI Build #20200113.49 succeeded
Details
roslyn-CI (Linux_Test coreclr) Linux_Test coreclr succeeded
Details
roslyn-CI (SourceBuild_Test) SourceBuild_Test succeeded
Details
roslyn-CI (Windows_CoreClr_Unit_Tests debug) Windows_CoreClr_Unit_Tests debug succeeded
Details
roslyn-CI (Windows_CoreClr_Unit_Tests release) Windows_CoreClr_Unit_Tests release succeeded
Details
roslyn-CI (Windows_Correctness_Test) Windows_Correctness_Test succeeded
Details
roslyn-CI (Windows_Desktop_Spanish_Unit_Tests) Windows_Desktop_Spanish_Unit_Tests succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests debug_32) Windows_Desktop_Unit_Tests debug_32 succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests debug_64) Windows_Desktop_Unit_Tests debug_64 succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests release_32) Windows_Desktop_Unit_Tests release_32 succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests release_64) Windows_Desktop_Unit_Tests release_64 succeeded
Details
roslyn-CI (Windows_Determinism_Test) Windows_Determinism_Test succeeded
Details
roslyn-CI (macOS_Test) macOS_Test succeeded
Details
roslyn-integration-CI Build #20200113.49 succeeded
Details
roslyn-integration-CI (VS_Integration debug_async) VS_Integration debug_async succeeded
Details
roslyn-integration-CI (VS_Integration release_async) VS_Integration release_async succeeded
Details
@msftbot msftbot bot deleted the merges/master-to-master-vs-deps branch Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.