Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract out simplification changes #40948

Merged
merged 23 commits into from Jan 15, 2020
Merged

Conversation

@CyrusNajmabadi
Copy link
Contributor

CyrusNajmabadi commented Jan 14, 2020

Pulling out independent parts of #40746 to make that PR simpler.

This PR should be reviewed with whitespace off.

Specific changes:

  1. Unify patterns in extension methods.
  2. Convert private extensions called from 1 location into normal static methods.
  3. Make public extensions only called from one place private.
  4. Compute symbol being reduced only once and pass along to all simplification helpers.
  5. Remove codepaths dealing with 'candidate' symbols. Later code bails out with ambiguities, so no need to deal with them earlier.
@CyrusNajmabadi CyrusNajmabadi requested a review from dotnet/roslyn-ide as a code owner Jan 14, 2020
@CyrusNajmabadi

This comment has been minimized.

Copy link
Contributor Author

CyrusNajmabadi commented Jan 14, 2020

Tagging @sharwell

@sharwell sharwell force-pushed the CyrusNajmabadi:simplifyTweaks branch from ef5f50d to 3b4d09f Jan 14, 2020
@CyrusNajmabadi

This comment has been minimized.

Copy link
Contributor Author

CyrusNajmabadi commented Jan 15, 2020

@sharwell @dpoeschl this is ready for review.

@CyrusNajmabadi

This comment has been minimized.

Copy link
Contributor Author

CyrusNajmabadi commented Jan 15, 2020

@sharwell feel free to merge.

@sharwell sharwell merged commit d971cd0 into dotnet:master Jan 15, 2020
18 checks passed
18 checks passed
WIP Ready for review
Details
license/cla All CLA requirements met.
Details
roslyn-CI Build #20200114.33 succeeded
Details
roslyn-CI (Linux_Test coreclr) Linux_Test coreclr succeeded
Details
roslyn-CI (SourceBuild_Test) SourceBuild_Test succeeded
Details
roslyn-CI (Windows_CoreClr_Unit_Tests debug) Windows_CoreClr_Unit_Tests debug succeeded
Details
roslyn-CI (Windows_CoreClr_Unit_Tests release) Windows_CoreClr_Unit_Tests release succeeded
Details
roslyn-CI (Windows_Correctness_Test) Windows_Correctness_Test succeeded
Details
roslyn-CI (Windows_Desktop_Spanish_Unit_Tests) Windows_Desktop_Spanish_Unit_Tests succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests debug_32) Windows_Desktop_Unit_Tests debug_32 succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests debug_64) Windows_Desktop_Unit_Tests debug_64 succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests release_32) Windows_Desktop_Unit_Tests release_32 succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests release_64) Windows_Desktop_Unit_Tests release_64 succeeded
Details
roslyn-CI (Windows_Determinism_Test) Windows_Determinism_Test succeeded
Details
roslyn-CI (macOS_Test) macOS_Test succeeded
Details
roslyn-integration-CI Build #20200114.33 succeeded
Details
roslyn-integration-CI (VS_Integration debug_async) VS_Integration debug_async succeeded
Details
roslyn-integration-CI (VS_Integration release_async) VS_Integration release_async succeeded
Details
@CyrusNajmabadi CyrusNajmabadi deleted the CyrusNajmabadi:simplifyTweaks branch Jan 15, 2020
@jinujoseph jinujoseph added this to InQueue in IDE: CommunityPR via automation Jan 15, 2020
@jinujoseph jinujoseph moved this from InQueue to Completed in IDE: CommunityPR Jan 15, 2020
@jinujoseph jinujoseph added this to the 16.5.P3 milestone Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
IDE: CommunityPR
  
Completed-163
3 participants
You can’t perform that action at this time.