Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release/dev16.5 to master #41683

Merged
merged 1 commit into from Feb 14, 2020
Merged

Merge release/dev16.5 to master #41683

merged 1 commit into from Feb 14, 2020

Conversation

@dotnet-bot
Copy link
Contributor

dotnet-bot commented Feb 14, 2020

This is an automatically generated pull request from release/dev16.5 into master.

git fetch --all
git checkout merges/release/dev16.5-to-master
git reset --hard upstream/master
git merge upstream/release/dev16.5
# Fix merge conflicts
git commit
git push upstream merges/release/dev16.5-to-master --force

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request.

The changes made in #41123 fix the
GetHashCode for SubstitutedMethodSymbol for more nullability scenarios,
but end up hashing all generic methods with a non-generic containing
type into the same bucket. This can cause large performance regressions
for the compiler.

This change ensures that substituted symbols which have substitutions
equivalent to their original methods' type parameter continue to be
equal, but substituted methods with different type substitutions are not
considered equal.
@dotnet-bot dotnet-bot requested a review from dotnet/roslyn-compiler as a code owner Feb 14, 2020
@msftbot
msftbot bot approved these changes Feb 14, 2020
Copy link
Contributor

msftbot bot left a comment

Auto-approval

@msftbot msftbot bot merged commit e8a68c4 into master Feb 14, 2020
18 checks passed
18 checks passed
WIP Ready for review
Details
license/cla All CLA requirements met.
Details
roslyn-CI Build #20200213.79 succeeded
Details
roslyn-CI (Linux_Test coreclr) Linux_Test coreclr succeeded
Details
roslyn-CI (SourceBuild_Test) SourceBuild_Test succeeded
Details
roslyn-CI (Windows_CoreClr_Unit_Tests debug) Windows_CoreClr_Unit_Tests debug succeeded
Details
roslyn-CI (Windows_CoreClr_Unit_Tests release) Windows_CoreClr_Unit_Tests release succeeded
Details
roslyn-CI (Windows_Correctness_Test) Windows_Correctness_Test succeeded
Details
roslyn-CI (Windows_Desktop_Spanish_Unit_Tests) Windows_Desktop_Spanish_Unit_Tests succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests debug_32) Windows_Desktop_Unit_Tests debug_32 succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests debug_64) Windows_Desktop_Unit_Tests debug_64 succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests release_32) Windows_Desktop_Unit_Tests release_32 succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests release_64) Windows_Desktop_Unit_Tests release_64 succeeded
Details
roslyn-CI (Windows_Determinism_Test) Windows_Determinism_Test succeeded
Details
roslyn-CI (macOS_Test) macOS_Test succeeded
Details
roslyn-integration-CI Build #20200213.79 succeeded
Details
roslyn-integration-CI (VS_Integration debug_async) VS_Integration debug_async succeeded
Details
roslyn-integration-CI (VS_Integration release_async) VS_Integration release_async succeeded
Details
@msftbot msftbot bot deleted the merges/release/dev16.5-to-master branch Feb 14, 2020
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-master branch Feb 14, 2020
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-master branch Feb 14, 2020
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-master branch Feb 14, 2020
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-master branch Feb 14, 2020
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-master branch Feb 14, 2020
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-master branch Feb 14, 2020
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-master branch Feb 14, 2020
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-master branch Feb 14, 2020
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-master branch Feb 14, 2020
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-master branch Feb 14, 2020
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-master branch Feb 14, 2020
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-master branch Feb 14, 2020
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-master branch Feb 14, 2020
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-master branch Feb 14, 2020
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-master branch Feb 15, 2020
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-master branch Feb 15, 2020
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-master branch Feb 15, 2020
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-master branch Feb 15, 2020
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-master branch Feb 15, 2020
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-master branch Feb 15, 2020
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-master branch Feb 15, 2020
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-master branch Feb 15, 2020
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-master branch Feb 16, 2020
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-master branch Feb 16, 2020
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-master branch Feb 16, 2020
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-master branch Feb 16, 2020
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-master branch Feb 16, 2020
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-master branch Feb 16, 2020
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-master branch Feb 16, 2020
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-master branch Feb 16, 2020
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-master branch Feb 16, 2020
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-master branch Feb 16, 2020
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-master branch Feb 17, 2020
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-master branch Feb 17, 2020
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-master branch Feb 17, 2020
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-master branch Feb 17, 2020
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-master branch Feb 17, 2020
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-master branch Feb 17, 2020
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-master branch Feb 17, 2020
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-master branch Feb 17, 2020
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-master branch Feb 17, 2020
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-master branch Feb 17, 2020
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-master branch Feb 17, 2020
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-master branch Feb 17, 2020
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-master branch Feb 17, 2020
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-master branch Feb 17, 2020
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-master branch Feb 17, 2020
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-master branch Feb 17, 2020
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-master branch Feb 18, 2020
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-master branch Feb 18, 2020
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-master branch Feb 18, 2020
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-master branch Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.