Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When generating abstract members, generate them as protected, not internal #42780

Merged
merged 2 commits into from Mar 26, 2020

Conversation

@CyrusNajmabadi
Copy link
Contributor

CyrusNajmabadi commented Mar 25, 2020

This is much more idiomatic as abstract methods are much more likely to be exposed as protected rather than internal.

Note: there is no need to check parameter types. in all the cases we could have exposed an internal method, we can still expose a protected method. that method may technically not be usable outside of your asseembly (due to referencing internal types), but still is idiomatic for how you would do an abstract method.

@CyrusNajmabadi CyrusNajmabadi requested a review from dotnet/roslyn-ide as a code owner Mar 25, 2020
@CyrusNajmabadi CyrusNajmabadi requested a review from ryzngard Mar 25, 2020
@msftbot
msftbot bot approved these changes Mar 25, 2020
Copy link
Contributor

msftbot bot left a comment

Auto-approval

@msftbot msftbot bot merged commit 5e1bec2 into dotnet:master Mar 26, 2020
18 checks passed
18 checks passed
WIP Ready for review
Details
license/cla All CLA requirements met.
Details
roslyn-CI Build #20200325.56 succeeded
Details
roslyn-CI (Linux_Test coreclr) Linux_Test coreclr succeeded
Details
roslyn-CI (SourceBuild_Test) SourceBuild_Test succeeded
Details
roslyn-CI (Windows_CoreClr_Unit_Tests debug) Windows_CoreClr_Unit_Tests debug succeeded
Details
roslyn-CI (Windows_CoreClr_Unit_Tests release) Windows_CoreClr_Unit_Tests release succeeded
Details
roslyn-CI (Windows_Correctness_Test) Windows_Correctness_Test succeeded
Details
roslyn-CI (Windows_Desktop_Spanish_Unit_Tests) Windows_Desktop_Spanish_Unit_Tests succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests debug_32) Windows_Desktop_Unit_Tests debug_32 succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests debug_64) Windows_Desktop_Unit_Tests debug_64 succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests release_32) Windows_Desktop_Unit_Tests release_32 succeeded
Details
roslyn-CI (Windows_Desktop_Unit_Tests release_64) Windows_Desktop_Unit_Tests release_64 succeeded
Details
roslyn-CI (Windows_Determinism_Test) Windows_Determinism_Test succeeded
Details
roslyn-CI (macOS_Test) macOS_Test succeeded
Details
roslyn-integration-CI Build #20200325.56 succeeded
Details
roslyn-integration-CI (VS_Integration debug_async) VS_Integration debug_async succeeded
Details
roslyn-integration-CI (VS_Integration release_async) VS_Integration release_async succeeded
Details
@jinujoseph jinujoseph added this to the 16.6.P3 milestone Mar 26, 2020
@CyrusNajmabadi CyrusNajmabadi deleted the CyrusNajmabadi:protectedAbstract branch Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.