Correctly use langword for this and base keywords #49232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❔ Is there a VB equivalent that would need |
I thought about this. I even discussed it on stream. And somehow I convinced myself that because those words wouldn't come up naturally when writing a comment, it wasn't necessary. Which of course I realise now is exactly the opposite conclusion to make 🤦♂️🤦♂️ |
src/EditorFeatures/CSharpTest/ReplaceDocCommentTextWithTag/ReplaceDocCommentTextWithTagTests.cs
Outdated
Show resolved
Hide resolved
allisonchou
approved these changes
Nov 11, 2020
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38370
"This" is a very common keyword that probably doesn't need to offer a refactoring, but given that this doesn't show squiggles to the user, it seemed not worth the trouble to create a deny list for one keyword.
Happy to follow up if others disagree.